fix: extract mod to file should respect path attribute #17216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
Veykril
reviewed
May 13, 2024
Comment on lines
+136
to
+137
| mod expr; | ||
| //- /parser/expr.rs |
There was a problem hiding this comment.
This won't be correct, the module would need to be at /parser/__mod/expr.rs for this to be loaded no?
There was a problem hiding this comment.
parser/expr.rs can be loaded.
IMO, with #path specified, parser/__mod.rs for mod parser(in the following code), can be seen as parser/mod.rs
#[path="parser/__mod.rs"]
mod parser;There was a problem hiding this comment.
Right, thanks for double checking.
Veykril
added
S-waiting-on-author
|
@bors r+ |
|
☀️ Test successful - checks-actions |
This was referenced May 28, 2024
This was referenced Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #17181