Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

blanket implementations of ParseError #900

Closed
Geal opened this issue Apr 6, 2019 · 4 comments
Closed

blanket implementations of ParseError #900

Geal opened this issue Apr 6, 2019 · 4 comments
Milestone
5.0

Comments

@Geal
Copy link
Collaborator

Geal commented Apr 6, 2019

to avoid orphan instances with ParseError, we should have predefined implementations for common error types people might use. Right now I see:

  • (Input, ErrorKind)(which is the default error type)
  • ()
    anything else?
@Geal Geal added this to the 5.0 milestone Apr 6, 2019
@Geal Geal mentioned this issue Apr 6, 2019
Closed
22 tasks
@loewenheim
Copy link

IIUC the first impl already exists and the second is simple, right?

@Geal
Copy link
Collaborator Author

Geal commented Apr 9, 2019

the first exists, but you're free to do the second :)
Any idea of other common error types someone could use?

@loewenheim
Copy link

I did the one for (), should I open a PR? And as for other common error types, I have no idea, sorry :(

@Geal
Copy link
Collaborator Author

Geal commented Apr 9, 2019

sure, please do :)

@Geal Geal closed this as completed May 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.0
Development

No branches or pull requests
2 participants
@Geal @loewenheim