New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc_comment::doctest!() is never called #987

Closed

0ndorio opened this issue Jul 7, 2019 · 1 comment

Contributor

0ndorio commented Jul 7, 2019

It seems that the test feature requirement for the doctest!() macro currently disables the validation of the tests cases inside the README.md file.

https://github.com/Geal/nom/blob/f40e4a74bd25abea2d2de306476c143dd0e9a181/src/lib.rs#L425-L426

I assume that the reason here is rustdoc not using the test flag (rust-lang/rust#61199). So this will not work until rust-lang/rust#61351 and rust-lang/rust#62213 are merged and we change the l.425 into #[cfg(doctest)].

The text was updated successfully, but these errors were encountered:

Collaborator

Geal commented Jul 11, 2019

thanks for the report, I moved to cfg(doctest) in d4d79d0

Geal closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment