Feature-gate the executable auto-download #102
Conversation
This way all the build-deps are not used when auto-download is not required granting a MSRV of 1.41.1
RCasatta
force-pushed
the
make_download_optional
branch
from
2dcfc7a to
67bb3da
Compare
src/lib.rs
Outdated
| @@ -294,6 +294,8 @@ impl BitcoinD { | |||
| p2p_args, | |||
| conf_args | |||
| ); | |||
|
|
|||
| #[allow(clippy::needless_borrow)] // would break 1.41.1 if fixed | |||
There was a problem hiding this comment.
FYI you can configure clippy to know about your MSRV and not suggest wrong things.
|
Seems like the right kind of thing to me. Very glad to see this addressed! |
|
MSRV seems impossibly confusing to maintain. when I |
|
did Kixunil/payjoin#40 (comment) fix your issue? |
|
Not yet because I'm not sure how to figure out which particular dependency is causing MSRV to be higher than I'd like. |
|
I do it by trial-error approach. Just try to compile it and whichever returns error I check the changelog and downgrade. It's a bit tedious but not too terrible. |
This way all the build-deps are not used when auto-download is not required granting a MSRV of 1.41.1
While 1.57 is required if auto-download feature is used
closes #88
could help with #100 and #95