Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow descriptor wallet creation #223

Open
rajarshimaitra opened this issue May 18, 2022 · 1 comment
Open

Allow descriptor wallet creation #223

rajarshimaitra opened this issue May 18, 2022 · 1 comment

Comments

@rajarshimaitra
Copy link

rajarshimaitra commented May 18, 2022

The current RpcApi defaults to creating legacy wallet. Is it possible to set an extra option to choose to create a descriptor wallet instead??

fn create_wallet(
&self,
wallet: &str,
disable_private_keys: Option<bool>,
blank: Option<bool>,
passphrase: Option<&str>,
avoid_reuse: Option<bool>,
) -> Result<json::LoadWalletResult> {
let mut args = [
wallet.into(),
opt_into_json(disable_private_keys)?,
opt_into_json(blank)?,
opt_into_json(passphrase)?,
opt_into_json(avoid_reuse)?,
];
self.call(
"createwallet",
handle_defaults(&mut args, &[false.into(), false.into(), into_json("")?, false.into()]),
)
}

Also would be really helpful to open up importdescriptors call to RpcApi..

@dunxen
Copy link

dunxen commented May 27, 2022

Looks like this is dependent on #199

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants