Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should the wg volunteer to maintain winapi? #91

Closed
AlexEne opened this issue Feb 28, 2020 · 8 comments
Closed

Should the wg volunteer to maintain winapi? #91

AlexEne opened this issue Feb 28, 2020 · 8 comments

Comments

@AlexEne
Copy link
Member

AlexEne commented Feb 28, 2020

retep998/winapi-rs#867

Why?

This fits into the foundational crates category mentioned in the wg charter.
Game developers are mainly using windows

Why not?

Extra work for us to merge things in it from time to time and maybe set up some extra tests, etc.?

The why in my opinion outweighs the why not so therefore I made this proposal here.

@AlexEne AlexEne changed the title Should the wg take on maintaining winapi? Should the wg volunteer to maintain winapi? Feb 29, 2020
@Lokathor
Copy link
Member

Lokathor commented Mar 1, 2020

Well obviously we should ping @retep998 to see if they're even interested in the idea.

@retep998
Copy link

retep998 commented Mar 1, 2020

I have been pinged.

@Lokathor
Copy link
Member

Lokathor commented Mar 1, 2020

... to see if they're even interested in the idea.

@minecrawler
Copy link

@Lokathor
if I understood the linked issue in the OP correctly, @retep998 does not have the time and motivation to continue development on winapi-rs at the moment:

I do lack the time and willpower to maintain winapi by myself

and is open to others offering help maintaining the project:

Are you offering to help [..] ?

From there, the following questions do have to be answered:

  • does the WG want to maintain the crate?
  • how would that look like? Would @retep998 have to transfer the project and all rights to the WG?
  • would @retep998 agree to such terms?

@Lokathor
Copy link
Member

Lokathor commented Mar 2, 2020

Well with that bullet point list:

  • Speaking for just myself: We should help winapi where we can.
  • I don't think the repo needs to move, though it could. The main thing to be gained by a move would be to help signal to the ecosystem that the crate is moving to be more community managed instead of being basically all work put on retep998 all the time.
  • Bullet three is the one I pinged retep998 for in the first place.

@AlexEne
Copy link
Member Author

AlexEne commented Mar 2, 2020

I think it should move somewhere (an org) where at least more ppl have merge rights, as there are a bunch of open PRs that are important. For example this.
I don't mind it being part of this wg github org, or it can have its own organization. Right now we have an author with no time to maintain it, getting it in a place where at least changes are merged / declined in a reasonable timeframe is a big improvement (even with no active development).

I do think it fits under the wg umbrella as it's a foundational crate.

Moving repos is easy, the author has to be a member of this github org, keeps all admin rights and more ppl join as maintainers. More people can be contributors, etc.

I would be also interested what other wg members think about doing this.

@retep998
Copy link

retep998 commented Mar 2, 2020

If the winapi repo is going to be moved to a working group, it should be moved to the windows wg: https://github.com/rust-windows/wg

@AlexEne
Copy link
Member Author

AlexEne commented Mar 2, 2020

Didn't know about the windows wg. Makes sense

@AlexEne AlexEne closed this as completed Mar 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants