Skip to content
This repository has been archived by the owner on Aug 20, 2021. It is now read-only.

Deprecate the tempdir crate #45

Closed
KodrAus opened this issue Feb 7, 2018 · 11 comments
Closed

Deprecate the tempdir crate #45

KodrAus opened this issue Feb 7, 2018 · 11 comments

Comments

@KodrAus
Copy link
Contributor

KodrAus commented Feb 7, 2018

In Stebalien/tempfile#33 we combined the tempdir and tempfile APIs, with the goal of using the tempfile crate as the source of temporary files and directories going forward.

I've gone through and review the open issues here (and basically just closed them all). I think the next step is to propose deprecating this repository and moving into rust-lang-deprecated, with a note in the readme that tempfile is the place to go for temporary directories going forward.

What do you all think? Is there anything else we should consider?

@steveklabnik
Copy link

Is there any way we can signal this change to users? If I hadn't been subscribed here, I'd have had no idea.

@KodrAus
Copy link
Contributor Author

KodrAus commented Feb 7, 2018

Yeh, we'll definitely need to do that, I was hoping we could wait until there's a published version of tempfile folks can immediately get before we do though.

Maybe we can add a notice to the readme here now pointing users wanting to open issues to tempfile but note that tempdir 0.3.6 is still available in the meantime?

@Stebalien do you have a plan in mind for the next release of tempfile? It would need to be a 3.0.0 wouldn't it, unless we go back and deprecate/shim the changed APIs on NamedTempFile.

@Stebalien
Copy link

Yes, it would need a 3.0.0. Issue here: Stebalien/tempfile#43

@Stebalien
Copy link

3.0.0 has been released.

@KodrAus
Copy link
Contributor Author

KodrAus commented Apr 17, 2018

Awesome! This is exciting news!

So the next steps would be to shift this repository into the deprecated org, and put out some comms pointing folks to tempfile.

@Stebalien Were you planning to do a release announcement for the new version for tempfile?

@Stebalien
Copy link

So... Those usually go on reddit but I managed to lose my reddit password and have found that I really don't make another account (I spend enough time just reading reddit as it is).

Given that you did 99% of the work in this endeavor, want to make the announcement?

@KodrAus
Copy link
Contributor Author

KodrAus commented Apr 18, 2018

No problem 👍 I'll put something together along with a note about the tempdir deprecation and put it out tomorrow.

@KodrAus
Copy link
Contributor Author

KodrAus commented Apr 19, 2018

The announcement has been posted!

I'll work on the RFC to shift tempdir into the deprecated organisation.

@KodrAus
Copy link
Contributor Author

KodrAus commented Oct 15, 2018

:) I just came here to write an RFC for shifting into the deprecated org and found it was already here! I'll go ahead and close this one now.

@KodrAus KodrAus closed this as completed Oct 15, 2018
@jethrogb
Copy link

@KodrAus as you correctly note an RFC is required for deprecation. This crate should be moved back to the nursery until such a time as deprecation has been approved.

@KodrAus
Copy link
Contributor Author

KodrAus commented Jan 13, 2019

@jethrogb What exactly do you hope to achieve by returning tempdir to the nursery?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants