Enforce timeouts for reading rustc version. #1071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some rustc versions (1.3.0 through 1.10.0 if my analysis is correct) are no longer working in recent macOS Sierra, in that they do not produce a correct output nor do not properly terminate in a timely manner (e.g. loops indefinitely). Having them in the current toolchain makes `rustup update` or (sometimes) `rustup show` unresponsive, so a timeout of one second has been added to correctly show that they are no longer working. Fixes rust-lang#766.
|
I have no idea why the test fails on Windows... (The comment "TempDir seems to succumb to difficulties removing dirs on windows" is quite suggestive.) |
|
@bors r+ Thanks! That test has been very flaky recently :( |
|
📌 Commit 809bff6 has been approved by |
bors
added a commit
that referenced
this pull request
Apr 19, 2017
Enforce timeouts for reading rustc version. Some rustc versions (1.3.0 through 1.10.0 if my analysis is correct) are no longer working in recent macOS Sierra, in that they do not produce a correct output nor do not properly terminate in a timely manner (e.g. loops indefinitely). Having them in the current toolchain makes `rustup update` or (sometimes) `rustup show` unresponsive, so a timeout of one second has been added to correctly show that they are no longer working. Fixes #766.
|
💔 Test failed - status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some rustc versions (1.3.0 through 1.10.0 if my analysis is correct) are no longer working in recent macOS Sierra, in that they do not produce a correct output nor do not properly terminate in a timely
manner (e.g. loops indefinitely).
Having them in the current toolchain makes
rustup updateor (sometimes)rustup showunresponsive, so a timeout of one second has been added to correctly show that they are no longer working.Fixes #766.