Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Website updates #363

Merged
merged 9 commits into from
Apr 28, 2016
Merged

Website updates #363

merged 9 commits into from
Apr 28, 2016

Conversation

brson
Copy link
Contributor

@brson brson commented Apr 27, 2016

Restyle the website to look like rust-lang.org, fix platform detection for a few cases. Preview.

Fixes #256

@brson
Copy link
Contributor Author

brson commented Apr 27, 2016

You can type "test" on the website to cycle through all the platform-specific instructions.

@alexcrichton
Copy link
Member

I'm pretty excited about this!

cc @aturon, @steveklabnik, @wycats

@brson brson force-pushed the www branch 2 times, most recently from afbc59f to fab82da Compare April 27, 2016 06:49
@brson
Copy link
Contributor Author

brson commented Apr 27, 2016

I put a big red warning back on there. It's still not ready to recommend without reservation.

@aturon
Copy link
Member

aturon commented Apr 27, 2016

This looks pretty great to me.

Really the only nitpick I have is whether we should try to be more clear about what rustup offers beyond being "the ultimate way to install Rust" (e.g., talking about cross-compilation components). Though I love the spirit of the current phrasing :)

@steveklabnik
Copy link
Member

I am still having issues seeing the fonts. Linux/Iceweasel here. Hrm. :(

Trying to diagnose.

@ashleygwilliams
Copy link
Member

hey ya'll! you can save on requests by asking for all of the google fonts at one, e.g. https://github.com/ashleygwilliams/jsconf-2015-deck/blob/gh-pages/public/custom.css#L1

i am happy to make a PR to fix this once this lands, or you could refactor on your own :)

@steveklabnik
Copy link
Member

Changing my font-family to remove Fira Sans will allow this to render.

Gah.

@steveklabnik
Copy link
Member

@brson I think this is due to @import. The same thing does work for me on the main rust page with @font-face.

@bors
Copy link
Contributor

bors commented Apr 27, 2016

☔ The latest upstream changes (presumably #359) made this pull request unmergeable. Please resolve the merge conflicts.

@nodakai
Copy link
Contributor

nodakai commented Apr 27, 2016

I think I'm experiencing the same problem with @steveklabnik .

Google Chrome 50.0.2661.75
new-rustup-website-chrome50

Iceweasel 45.0.1
new-rustup-website-iceweasel45

Both on Debian testing x86_64

brson added 5 commits April 28, 2016 00:22
Adds link for additional installation methods. Indicates the officialness
of the project. Improves Linux, FreeBSD, arm, Android platform detection.

Adds unique installation text for Android.

Removes most of the pitch to make more room.

Fixes rust-lang#269. Fixes rust-lang#328
@brson
Copy link
Contributor Author

brson commented Apr 28, 2016

hey ya'll! you can save on requests by asking for all of the google fonts at one, e.g. https://github.com/ashleygwilliams/jsconf-2015-deck/blob/gh-pages/public/custom.css#L1

Thanks, I'll go ahead and make the change.

Really the only nitpick I have is whether we should try to be more clear about what rustup offers beyond being "the ultimate way to install Rust" (e.g., talking about cross-compilation components). Though I love the spirit of the current phrasing :)

I'll think about rephrasing it to show more and tell less.

@brson I think this is due to @import. The same thing does work for me on the main rust page with @font-face.

I'll switch to @font-face.

I think I'm experiencing the same problem with @steveklabnik .

Thanks for the screenshots. I'll try with @font-face.

@brson
Copy link
Contributor Author

brson commented Apr 28, 2016

I pushed another revision. This one uses @font-face instead of @import, but @ashleygwilliams since I switched away from @import I didn't know how to merge them into one declaration.

I changed the warning to just say "this is beta software", remove "expect breakage".

I don't yet have anything else I like better for the pitch, but I removed 'ultimate'. Now it just says the plain fact, 'rustup is an installer for the systems programming language Rust'. I'm somewhat disinclined to try to 'sell' rustup here, for two reasons: rustup is the Rust installer, and if you want Rust you've got to click that button. The user already knows they want Rust. This is how you get Rust.

Furthermore, I'm not sure there's much more that can be explained without many more words. The most import features of rustup are installation, updates, channel tracking, and installation of cross-compilation targets. So you might say "rustup is an installer for the systems programming language Rust. It keeps your installation up to date, manages multiple Rust toolchains, and makes cross-compilation easier," possibly with another link to a more complete pitch.

@brson brson mentioned this pull request Apr 28, 2016
@nodakai
Copy link
Contributor

nodakai commented Apr 28, 2016

Fonts look fine now:
new-rustup-website-chrome50-1

@steveklabnik
Copy link
Member

They work for me too 👍

@brson brson merged commit f777bd1 into rust-lang:master Apr 28, 2016
@brson
Copy link
Contributor Author

brson commented Apr 28, 2016

Going with it as is for now.

AJ-Ianozi pushed a commit to AJ-Ianozi/getada-download that referenced this pull request Mar 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Restyle website to look more like rust-lang.org
7 participants