Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic autocompletion for Zsh #689

Merged
merged 1 commit into from
Aug 26, 2016

Conversation

knight42
Copy link
Contributor

Unsolved problem:

Should I hard code this file into somewhere and generate it in a proper place, say ~/.cargo/_rustup(then ask users to copy it to /usr/share/zsh/site-functions),

or simply let rustup copy this file to ~/.cargo/_rustup?

@knight42
Copy link
Contributor Author

part of #278

@Diggsey
Copy link
Contributor

Diggsey commented Aug 25, 2016

I'm a little concerned about keeping this up to date with the CLI, but we can add it for now on the basis that slightly out-of-date completions are better than no completions, and our CLI aims to be backwards compatible.

However, I'd prefer not to clutter the root directory with this. src/rustup-cli/zsh/_rustup should be fine, and we should link to it from the README under installation instructions.

Regarding actual installation, for now just providing them in the repo is better than nothing. When we figure out the best way to install it automatically, we can always include! the completions file into the rustup binary.

@knight42
Copy link
Contributor Author

@Diggsey updated as you said :)

@Diggsey
Copy link
Contributor

Diggsey commented Aug 26, 2016

Thanks! Test failure looks spurious, so merging this.

@Diggsey Diggsey merged commit 0f03f9a into rust-lang:master Aug 26, 2016
@knight42 knight42 deleted the zsh-auto-completion branch September 1, 2016 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants