Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency handlebars to v6 for mdman #14764

Closed
weihanglo opened this issue Nov 1, 2024 · 1 comment · Fixed by #14772
Closed

Update dependency handlebars to v6 for mdman #14764

weihanglo opened this issue Nov 1, 2024 · 1 comment · Fixed by #14772
Labels
A-cli-help Area: built-in command-line help C-cleanup Category: cleanup within the codebase E-easy Experience: Easy P-low Priority: Low S-accepted Status: Issue or feature is accepted, and has a team member available to help mentor or review

Comments

@weihanglo
Copy link
Member

Problem

Renovate bot found a newer version available for dependency handlebars in #14763. handlebars is used by mdman for templatizing and generating man pages.

However, the new version has some API changes that need to be fixed:

Build failure. Click to See details

   Compiling mdman v0.0.0 (/Users/runner/work/cargo/cargo/crates/mdman)
error[E0639]: cannot create non-exhaustive struct using struct expression
  --> crates/mdman/src/hbs.rs:27:19
   |
27 |       let options = DirectorySourceOptions {
   |  ___________________^
28 | |         tpl_extension: ".md".to_string(),
29 | |         hidden: false,
30 | |         temporary: false,
31 | |     };
   | |_____^

Steps

  1. Clone rust-lang/cargo
  2. Run cargo build-man
  3. Fix the build failure.

Possible Solution(s)

Look into what have been changed in handlebars and update accordingly.

Version

7421ccf9159d5ac43883c53abe41ef1da657acfd
@weihanglo weihanglo added A-cli-help Area: built-in command-line help C-cleanup Category: cleanup within the codebase E-easy Experience: Easy P-low Priority: Low S-accepted Status: Issue or feature is accepted, and has a team member available to help mentor or review labels Nov 1, 2024
@hcbarker
Copy link
Contributor

hcbarker commented Nov 1, 2024

I can do this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-cli-help Area: built-in command-line help C-cleanup Category: cleanup within the codebase E-easy Experience: Easy P-low Priority: Low S-accepted Status: Issue or feature is accepted, and has a team member available to help mentor or review
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants