Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cargo test for plugins fails on Windows when using rustup #3463

Closed
retep998 opened this issue Dec 27, 2016 · 2 comments
Closed

cargo test for plugins fails on Windows when using rustup #3463

retep998 opened this issue Dec 27, 2016 · 2 comments

Comments

@retep998
Copy link
Member

retep998 commented Dec 27, 2016

If a crate has plugin = true then any binaries crated by cargo test will depend on the DLL versions of Rust libraries instead of statically linking to them. If the directory containing the DLLs is not in PATH then the test binaries will fail to run. The most common way that this occurs is if the user is using rustup as recommended. So either rustup needs to make sure that directory is in PATH before forwarding to the actual cargo/rustc or cargo needs to make sure it adds that directory when running tests or possibly make tests statically link. The reason this is specific to Windows is because Windows does not have rpath, so the only way for the DLLs to be found is via PATH.

cc @brson

@retep998
Copy link
Member Author

Oh, this is a dupe of #3394

@alexcrichton
Copy link
Member

Ok, closing as a dupe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants