Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Symlinks are silently published as regular files #3896

Closed
kornelski opened this issue Apr 4, 2017 · 2 comments
Closed

Symlinks are silently published as regular files #3896

kornelski opened this issue Apr 4, 2017 · 2 comments

Comments

@kornelski
Copy link
Contributor

I've got an opposite problem of #2748 — in my package I needed a symlink for a test, but the symlink silently became a regular file in the copy obtained from crates.io.

I'd prefer the symlink to stay as a symlink, at least on non-Windows. Or an error/big warning during publishing that the symlink has been replaced.

@da-x
Copy link
Member

da-x commented Jan 25, 2019

Please note that some packages currently rely on this behavior. Example: https://github.com/serde-rs/serde/tree/bb99b31eb0a55393101f9c80cd959b3a739ad70f/serde (symlinks in the serde repo).

@kornelski
Copy link
Contributor Author

I think a nice compromise would be to keep symlink if it points to a file within the package, and copy if the symlink points to outside of the package (like the often used ../README symlink).

But given how annoying Windows is with its semi-support for symlinks, I probably have to resign to symlinks being lost.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants