cargo test --all --lib doesn't work on virtual manifests

[behnam]

The

cargo test --all

variation works fine in a virtual manifest, but surprisingly

cargo test --all --lib

doesn't, erring with:

error: no library targets found

I believe this is a bug, as the filters do make complete sense.

[alexcrichton]

Hm yeah I think I'd imagine a better error just saying you can't compose --all with more filters?

[behnam]

Oh, I'm doing that all the time! Specifically, test --all --lib works fine with a non-virtual workspace, it just panics in a virtual workspace.

[alexcrichton]

Hm ok, then yeah I guess we just need to implement and/or fix this, and interpret --all --lib as "test all libraries"?

[behnam]

Yeah, I think falls into the not-still-implemented---all category.

[stale]

As there hasn't been any activity here in over 6 months I've marked this as stale and if no further activity happens for 7 days I will close it.

I'm a bot so this may be in error! If this issue should remain open, could someone (the author, a team member, or any interested party) please comment to that effect?

The team would be especially grateful if such a comment included details such as:

• Is this still relevant?
• If so, what is blocking it?
• Is it known what could be done to help move this forward?

Thank you for contributing!

(The cargo team is currently evaluating the use of Stale bot, and using #6035 as the tracking issue to gather feedback.)

If you're reading this comment from the distant future, fear not if this was closed automatically. If you believe it's still an issue please leave a comment and a team member can reopen this issue. Opening a new issue is also acceptable!

[ehuss]

I believe this is fixed by #5873.

[inferiorhumanorgans]

I'm not 100% sure I'm not doing something wrong, but cargo test --all --lib doesn't appear to hit all the libraries defined in a virtual manifest.