Why checking the README path in the upload step?

[matthiasbeyer]

Why does cargo publish check the path to the repository README in the upload step? If the README path is wrong, it won't be noticed by publish --dry-run ... which is bad!

[matthiasbeyer]

Any pointers when this might be solved?

[dwijnand]

Hmm, I don't understand the ticket. I'm not sure, for instance, whether you're requesting a new feature or reporting a bug. Could you please restate it in terms of the reproduction steps, what you expected to happen and what instead happened?

[matthiasbeyer]

The checking of the readme path, whether the path is correct, happens just before cargo publish uploads. That is bad because a dry-run does not catch if the readme path in the cargo.toml is wrong.

Checking the path of the readme file should happen much more early in the publishing process.

[dwijnand]

Got it. Thank you!

[dwijnand]

I'm going to close this as invalid. The readme file is read here:

cargo/src/cargo/ops/registry.rs

Lines 222 to 225 in 2458180

	let readme_content = match *readme {
	Some(ref readme) => Some(paths::read(&pkg.root().join(readme))?),
	None => None,
	};

Which is before the dry-run, well before the publishing uploads:

cargo/src/cargo/ops/registry.rs

Lines 232 to 236 in 2458180

	// Do not upload if performing a dry run
	if dry_run {
	config.shell().warn("aborting upload due to dry run")?;
	return Ok(());
	}