Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bad_git_dependency test fails erroneously for 0.24.0 #4908

Closed
saintdev opened this issue Jan 6, 2018 · 5 comments
Closed

bad_git_dependency test fails erroneously for 0.24.0 #4908

saintdev opened this issue Jan 6, 2018 · 5 comments

Comments

@saintdev
Copy link

saintdev commented Jan 6, 2018

It seems the expected failure output does not match the actual failure output. The actual output still appears correct, just different.

     Running target/debug/deps/bad_config-34c3b300c9101ff4

running 37 tests
test ambiguous_git_reference ... ok
test bad2 ... ok
test bad1 ... ok
test bad4 ... ok
test bad3 ... ok
test bad5 ... ok
test bad_cargo_config_jobs ... ok
test bad_cargo_lock ... ok
test bad_debuginfo ... ok
test bad_dependency ... ok
test bad_dependency_in_lockfile ... ok
test bad_crate_type ... ok
test bad_git_dependency ... FAILED
test bad_opt_level ... ok
test bad_source_config1 ... ok
test bad_source_config2 ... ok
test bad_source_config3 ... ok
test bad_source_config4 ... ok
test bad_source_config5 ... ok
test bad_source_config6 ... ok
test bad_source_config7 ... ok
test bad_source_in_cargo_lock ... ok
test both_git_and_path_specified ... ok
test duplicate_bench_names ... ok
test duplicate_binary_names ... ok
test duplicate_deps ... ok
test duplicate_deps_diff_sources ... ok
test default_cargo_config_jobs ... ok
test duplicate_example_names ... ok
test duplicate_packages_in_cargo_lock ... ok
test good_cargo_config_jobs ... ok
test ignored_git_revision ... ok
test invalid_global_config ... ok
test empty_dependencies ... ok
test malformed_override ... ok
test invalid_toml_historically_allowed_is_warned ... ok
test unused_keys ... ok

failures:

---- bad_git_dependency stdout ----
	running `/home/build/YPKG/root/cargo/build/cargo-0.24.0/target/debug/cargo build -v`
thread 'bad_git_dependency' panicked at '
Expected: execs
    but: differences:
 10 - |  [[..]] 'file:///' is not a valid local file URI|
    + |  'file:///' is not a valid local file URI; class=Config (7)|


other output:
``', /home/build/.cargo/registry/src/github.com-1ecc6299db9ec823/hamcrest-0.1.1/src/core.rs:31:12
note: Run with `RUST_BACKTRACE=1` for a backtrace.


failures:
    bad_git_dependency

test result: FAILED. 36 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out

error: test failed, to rerun pass '--test bad-config'
@copyninja
Copy link
Contributor

Even I'm facing this issue while building cargo 0.24.0 for Debian. Actually I did execute same command manually using cargo where error output is as per test case in 0.23.0 but different when doing it with 0.24.0.

@copyninja
Copy link
Contributor

It looks like the error got introduced at this point 5c9665f as pointed out by git bisect. But I don't know how can deleting a Cargo.lock introduce different error message.
@alexcrichton any help will be appreciated (ccing you as you commited the above hash)

@alexcrichton
Copy link
Member

The failure here is benign and comes about from using a different version of git2-rs than is being tested in Cargo today. The test here should be updated to be less strict about the output and error message.

@stale
Copy link

stale bot commented Sep 17, 2018

As there hasn't been any activity here in over 6 months I've marked this as stale and if no further activity happens for 7 days I will close it.

I'm a bot so this may be in error! If this issue should remain open, could someone (the author, a team member, or any interested party) please comment to that effect?

The team would be especially grateful if such a comment included details such as:

  • Is this still relevant?
  • If so, what is blocking it?
  • Is it known what could be done to help move this forward?

Thank you for contributing!

(The cargo team is currently evaluating the use of Stale bot, and using #6035 as the tracking issue to gather feedback.)

If you're reading this comment from the distant future, fear not if this was closed automatically. If you believe it's still an issue please leave a comment and a team member can reopen this issue. Opening a new issue is also acceptable!

@stale stale bot added the stale label Sep 17, 2018
@stale
Copy link

stale bot commented Oct 18, 2018

As I didn't see any updates in 30 days I'm going to close this. Please see the previous comment for more information!

@stale stale bot closed this as completed Oct 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants