Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move CONTRIBUTING.md to rustc-dev-guide and instead point to Getting Started #320

Closed
2 of 3 tasks
mark-i-m opened this issue Jun 23, 2020 · 3 comments
Closed
2 of 3 tasks

Move CONTRIBUTING.md to rustc-dev-guide and instead point to Getting Started #320

mark-i-m opened this issue Jun 23, 2020 · 3 comments
Labels
major-change A proposal to make a major change to rustc major-change-accepted A major change proposal that was accepted T-compiler Add this label so rfcbot knows to poll the compiler team

Comments

@mark-i-m
Copy link
Member

mark-i-m commented Jun 23, 2020 •
edited
Loading

Proposal

The contributor survey showed that

  1. CONTRIBUTING.md is frequently used by contributors.
  2. A lot of contributors have a hard time finding out how to get started.

Thus, we are interested in making CONTRIBUTING.md a better starting point by moving it's current contents to rustc-dev-guide and instead having CONTRIBUTING.md point to the new Getting Started Guide.

Specifically, we want to merge these two PRs:

This is orthogonal to #296.

Mentors or Reviewers

@nikomatsakis

Process

The main points of the Major Change Process is as follows:

  • File an issue describing the proposal.
  • A compiler team member or contributor who is knowledgeable in the area can second by writing @rustbot second.
    • Finding a "second" suffices for internal changes. If however you are proposing a new public-facing feature, such as a -C flag, then full team check-off is required.
    • Compiler team members can initiate a check-off via @rfcbot fcp merge on either the MCP or the PR.
  • Once an MCP is seconded, the Final Comment Period begins. If no objections are raised after 10 days, the MCP is considered approved.

You can read more about Major Change Proposals on forge.

Comments

This issue is not meant to be used for technical discussion. There is a Zulip stream for that. Use this issue to leave procedural comments, such as volunteering to review, indicating that you second the proposal (or third, etc), or raising a concern that you would like to be addressed.
@mark-i-m mark-i-m added T-compiler Add this label so rfcbot knows to poll the compiler team major-change A proposal to make a major change to rustc labels Jun 23, 2020
@rustbot
Copy link
Collaborator

rustbot commented Jun 23, 2020

This issue is not meant to be used for technical discussion. There is a Zulip stream for that. Use this issue to leave procedural comments, such as volunteering to review, indicating that you second the proposal (or third, etc), or raising a concern that you would like to be addressed.

@rustbot rustbot added the to-announce Announce this issue on triage meeting label Jun 23, 2020
@nikomatsakis
Copy link
Contributor

@rustbot second

@rustbot

This comment has been minimized.

Sign in to view
@rustbot rustbot added the final-comment-period The FCP has started, most (if not all) team members are in agreement label Jun 23, 2020
@spastorino spastorino removed the to-announce Announce this issue on triage meeting label Jun 24, 2020
@ecstatic-morse ecstatic-morse mentioned this issue Jun 28, 2020
Open
@spastorino spastorino added major-change-accepted A major change proposal that was accepted and removed final-comment-period The FCP has started, most (if not all) team members are in agreement labels Jul 8, 2020
@rustbot rustbot added the to-announce Announce this issue on triage meeting label Jul 8, 2020
@spastorino spastorino removed the to-announce Announce this issue on triage meeting label Jul 8, 2020
@follower follower mentioned this issue Sep 25, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
major-change A proposal to make a major change to rustc major-change-accepted A major change proposal that was accepted T-compiler Add this label so rfcbot knows to poll the compiler team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@spastorino @nikomatsakis @mark-i-m @rustbot