Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Link to rust-lang/cargo-lockfile-sync in content/procedures/crates.md is invalid #523

Closed
NiklasJonsson opened this issue Jul 8, 2022 · 4 comments · Fixed by #524
Closed

Link to rust-lang/cargo-lockfile-sync in content/procedures/crates.md is invalid #523

NiklasJonsson opened this issue Jul 8, 2022 · 4 comments · Fixed by #524

Comments

@NiklasJonsson
Copy link
Contributor

The procedures/crates.md file links to https://github.com/rust-lang/cargo-lockfile-sync/ (at the very bottom) which results in a 404 for me. I don't mind fixing this but I'm not sure if it should be removed or replaced? I can't find anything similar by searching in rust-lang at least.
@wesleywiser
Copy link
Member

@oli-obk it looks like you added the reference to that repo back in 2019 (ad42c66). Do you know what happened to cargo-lockfile-sync?

I'm guessing it should probably just be removed.

@oli-obk
Copy link
Contributor

oli-obk commented Jul 8, 2022

I don't remember this

@bjorn3
Copy link
Member

bjorn3 commented Jul 8, 2022

According to rust-lang/rust#57443 (comment) it ended up in cargo-edit as cargo upgrade --to-lockfile.

@NiklasJonsson
Copy link
Contributor Author

PR is #524

@wesleywiser wesleywiser mentioned this issue Jul 8, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

remove invalid link to rust-lang/cargo-lockfile-sync NiklasJonsson/compiler-team
4 participants
@oli-obk @wesleywiser @NiklasJonsson @bjorn3