Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing --extern-html-root-url for optional dependencies #1165

Closed
Nemo157 opened this issue Nov 5, 2020 · 0 comments · Fixed by #1188
Closed

Missing --extern-html-root-url for optional dependencies #1165

Nemo157 opened this issue Nov 5, 2020 · 0 comments · Fixed by #1188
Labels
A-builds Area: Building the documentation for a crate C-bug Category: This is a bug

Comments

@Nemo157
Copy link
Member

Nemo157 commented Nov 5, 2020

If a dependency is optional it will not be picked up in the root dependencies cause this is not taking the [package.metadata.docs.rs] into account:

let ids = &self.deps_graph[&self.root_id];

Example: it has chrono active, but no --extern-html-root-url for it: https://docs.rs/crate/rusqlite/0.24.1/builds/301100

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-builds Area: Building the documentation for a crate C-bug Category: This is a bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants