-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scraping examples: works locally but not on docs.rs #2305
Comments
After talking to some folks from @rust-lang/docs-rs, we discovered that no scraped examples are shown for items that are re-exported from other crates. It works for path dependencies. |
This now needs to be moved to |
Have you tried minimizing this issue to not rely on Cargo but just on |
It works if the crate is specified with |
Moved the issue in docs.rs as it seems to be a docs.rs-specific issue: every crate gets its scraped examples working when documenting them locally. My guess is that maybe we are using a read-only FS when we should not. To be confirmed. |
@GuillaumeGomez from what I remember of the discussion with @killercup , we were able to reproduce this locally, perhaps @Nemo157 knows more? |
That's also what I remember and yet I can't reproduce it locally again. @killercup and I talked about it in killercup/test-rustdoc-example-scraping-across-workspace-on-docrs#1. The surprising part being that the docs.rs command line (with |
Yeah, my recollection is that the difference was that it didn't reproduce in the repository, but only in the published package, not anything to do with what docs.rs does with that package specifically. |
Ok, I'll keep the issue here for the time being and try to check what's going on when we get the crate from crates.io. |
So more information about this (for bevy): when adding back the workspace members: [workspace]
members = [
"crates/*",
] And copying the relevant files locally, the examples are scraped as expected. Next step is to take a look into cargo and figure out why it's even needed in the first place. |
Fixed in rust-lang/cargo#13074. |
In bevyengine/bevy#9154, I tried adding metadata to have the many examples bevy comes with show up in their API docs.
I have a full reproduction and detailed description of what I tried here: killercup/test-rustdoc-example-scraping-across-workspace-on-docrs#1
This relates to rust-lang/rust#88791
cc @rust-lang/docs-rs
(talked to @GuillaumeGomez about this already)
The text was updated successfully, but these errors were encountered: