Skip to content
This repository has been archived by the owner on Mar 14, 2023. It is now read-only.

Enable retry choose_reviewer #189

Open
h-michael opened this issue Jan 26, 2019 · 3 comments
Open

Enable retry choose_reviewer #189

h-michael opened this issue Jan 26, 2019 · 3 comments

Comments

@h-michael
Copy link

Sometimes, highfive fails assign reviewer. ex(rust-lang/rust#57913)
If PR owner doesn't know appropriate reviewer, they can't write r? by themselves.
So I want the way that re choose_reviewer action.
Something like r? _retry, r? _.(We can't use underscore to Github username)

@pietroalbini
Copy link
Member

Thanks for reporting this! I'd prefer if we fix the underlying cause of highfive crashing instead of adding patches to retry failures though. That specific crash was caused by #190.

@dwijnand
Copy link
Member

dwijnand commented Mar 2, 2019

I think the better workaround for #190 is #187.

@SimonSapin
Copy link
Contributor

I’ve opened #241 for a different use case, but the requested functionality is the same as here.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants