From 0effd9bd1cdb6851a3b0e980062cf31ee0391fc0 Mon Sep 17 00:00:00 2001 From: Yuki Okushi Date: Sun, 20 Nov 2022 13:29:42 +0900 Subject: [PATCH] Add pull request template Signed-off-by: Yuki Okushi --- .github/PULL_REQUEST_TEMPLATE.md | 10 ++++++++++ CONTRIBUTING.md | 2 +- 2 files changed, 11 insertions(+), 1 deletion(-) create mode 100644 .github/PULL_REQUEST_TEMPLATE.md diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md new file mode 100644 index 0000000000000..a4958ba8c5e64 --- /dev/null +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -0,0 +1,10 @@ +Thanks for considering submitting a PR! + +Here's a checklist for things that will be checked during review or continuous integration. + +- \[ ] Edit corresponding file(s) under `libc-test/semver` when you add/remove item(s) +- \[ ] `rustc ci/style.rs && ./style src` +- \[ ] `cd libc-test && cargo test` (This might fail on your env due to environment difference between your env and CI. Ignore failures if you are not sure.) +- \[ ] Your PR that bumps up the crate version doesn't contain any other changes + +Delete this line and everything above before opening your PR. diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 3315ed3e84f7e..8c551dbdb576e 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -86,7 +86,7 @@ it. If you'd like to get a release out ASAP you can follow these steps: 1. Increment the patch version number in `Cargo.toml` and `libc-test/Cargo.toml`. 1. Send a PR to this repository. It should [look like this][example-pr], but it'd also be nice to fill out the description with a small rationale for the - release (any rationale is ok though!) + release (any rationale is ok though!). 1. Once merged, the release will be tagged and published by one of the libc crate maintainers.