Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of raw_ext, metadata_ext and metadata_ext2 features for Apple WatchOS #75

Closed
vladimir-ea opened this issue Jul 20, 2022 · 2 comments
Labels
ACP-accepted API Change Proposal is accepted (seconded with no objections) api-change-proposal A proposal to add or alter unstable APIs in the standard libraries T-libs-api

Comments

@vladimir-ea
Copy link

Proposal

Problem statement

Add support for the raw_ext, metadata_ext and metadata_ext2 features for the Apple WatchOS platform.

Motivation, use-cases

rust-lang/rust#95243 Added compiler support for Apple WatchOS targets. rust-lang/rust#98101 Adds standard library support for Apple WatchOS. The motivation is to complete support for Apple WatchOS targets by implementing these features, giving parity of support for WatchOS as for other Apple platforms (e.g. iOS).

Solution sketches

Implementation for WatchOS will be identical to iOs implementations in the first instance.

Links and related work

For iOS implementations of these features see: https://github.com/rust-lang/rust/tree/master/library/std/src/os/ios

What happens now?

This issue is part of the libs-api team API change proposal process. Once this issue is filed the libs-api team will review open proposals in its weekly meeting. You should receive feedback within a week or two.

@thomcc
Copy link
Member

thomcc commented Sep 14, 2022

It's worth figuring out what we want to do here, since. My suggestion is just that we do what... basically every other platform we currently has does, and define these as they are, even if it means copy-pasting from the existing platforms.

That is, I think the assumption that these are the same as iOS is likely not something we want to make, since iOS and watchOS don't even have the same pointer size (e.g. despite both being aarch64, on watchOS pointers are 32 bits -- it's `arm64_32-apple-watchos).

I'm going to nominate this so that it will get into the API team discussion next week.

EDIT: Oh, it doesn't look like I can. I guess I'll nominate the impl PR.

@vladimir-ea
Copy link
Author

rust-lang/rust#99497 has been merged.

@dtolnay dtolnay added the ACP-accepted API Change Proposal is accepted (seconded with no objections) label Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ACP-accepted API Change Proposal is accepted (seconded with no objections) api-change-proposal A proposal to add or alter unstable APIs in the standard libraries T-libs-api
Projects
None yet
Development

No branches or pull requests

3 participants