Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement warnings for missing playpen files #355

Open
projektir opened this issue Jun 24, 2017 · 1 comment
Open

Implement warnings for missing playpen files #355

projektir opened this issue Jun 24, 2017 · 1 comment
Labels
A-CLI Area: CLI A-Playground Area: Playground C-papercut Category: A small usability bug

Comments

@projektir
Copy link
Contributor

projektir commented Jun 24, 2017

mdBook currently doesn't seem to say anything if I try to include a file that doesn't exist in a playpen. It would be nice to have a warning for that. This is a nice to have for #308.

There's a warning here, but I'm not entirely sure where it's meant to show up.

I think a good place for this would be mdBook test, unless we want this to be a build failure? mdbook test seems like a good place for various checks on the final document, even if it would involve extra work to find playpen links all over again. Could this be part of the linkchecker?

@azerupi
Copy link
Contributor

azerupi commented Jun 24, 2017

I think logging somehow got disabled at some point, that's not good.

I think a good place for this would be mdBook test

I think this is definitely something that should spawn at least a warning at build or even an error. Actually we could have a new config flag deny-warnings or something similar that would let you choose between warnings or errors.

I wouldn't put it in mdbook test alone because I'm not sure it is used that much, but it could be a check both in mdbook build and mdbook test

@azerupi azerupi added A-CLI Area: CLI C-papercut Category: A small usability bug labels Jun 24, 2017
@ehuss ehuss added the A-Playground Area: Playground label May 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-CLI Area: CLI A-Playground Area: Playground C-papercut Category: A small usability bug
Projects
None yet
Development

No branches or pull requests

3 participants