Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rendering graves in TOC #70

Closed
steveklabnik opened this issue Dec 14, 2015 · 3 comments
Closed

rendering graves in TOC #70

steveklabnik opened this issue Dec 14, 2015 · 3 comments
Milestone

Comments

@steveklabnik
Copy link
Member

Using graves for code styling as the title of a chapter works:

2015-12-14-114347_107x91_scrot

but renders literally in the sidebar:

2015-12-14-114343_123x34_scrot

I think the right thing to do here would be to just strip them on the sidebar, but I could see giving them some code styling too.

@azerupi azerupi added this to the 0.0.4 milestone Dec 14, 2015
@azerupi
Copy link
Contributor

azerupi commented Dec 14, 2015

Yes, markdown in the sidebar is not rendered at the moment. I am not sure if it should or not. I will do some tests and see what works best.

I read that you are trying out this crate for the official rust book and I am really flattered! :) I have to warn though, I have exams until end of January so I will not have a lot of time to work on it. If you need some changes sooner, you can send PR's. I will try to respond as quickly as I can. Or I can add you as contributor if you find it more convenient.

@steveklabnik
Copy link
Member Author

Yes. :)

Cool. I had wanted to ping you, I don't want to make it a burden, but also didn't want to implement PRs if you wanted to tackle them! Nothing here is super high priority, so I might send a fix, I might wait. But I certainly don't expect anyone to have a ton of free time until after the new year. 👍

On Dec 14, 2015, at 13:21, Mathieu David notifications@github.com wrote:

Yes, markdown in the sidebar is not rendered at the moment. I am not sure if it should or not. I will do some tests and see what works best.

I read that you are trying out this crate for the official rust book and I am really flattered! :) I have to warn though, I have exams until end of January so I will not have a lot of time to work on it. If you need some changes sooner, you can send PR's. I will try to respond as quickly as I can. Or I can add you as contributor if you find it more convenient.


Reply to this email directly or view it on GitHub.

@azerupi
Copy link
Contributor

azerupi commented Dec 14, 2015

didn't want to implement PRs if you wanted to tackle them!

I don't mind, I am always glad to see PR's! Just let me know if you are working on something, so that we avoid duplicate work 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants