Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

diff highlighting is not working #927

Closed
ehuss opened this issue May 17, 2019 · 0 comments · Fixed by #943
Closed

diff highlighting is not working #927

ehuss opened this issue May 17, 2019 · 0 comments · Fixed by #943
Labels
A-Highlighting Area: Code colored syntax highlighting A-Style Area: Style (CSS, etc.)

Comments

@ehuss
Copy link
Contributor

ehuss commented May 17, 2019

The diff language highlighting doesn't seem to work for me.

-        [preprocess.first]
+        [preprocessor.first]

-        [preprocess.second]
+        [preprocessor.second]

Looks like:
image

The current CSS hljs theme does not define the .hljs-addition and .hljs-deletion classes. Several other themes seem to define it, so maybe just add it (and see what other classes are missing).
@ehuss ehuss added A-Style Area: Style (CSS, etc.) A-Highlighting Area: Code colored syntax highlighting labels May 17, 2019
@ehuss ehuss mentioned this issue May 30, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Highlighting Area: Code colored syntax highlighting A-Style Area: Style (CSS, etc.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update css to support diff syntax highlighting. ehuss/mdBook
1 participant
@ehuss