Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find a way to enable overflow checks in distributed builds #2501

Open
RalfJung opened this issue Aug 22, 2022 · 0 comments
Open

Find a way to enable overflow checks in distributed builds #2501

RalfJung opened this issue Aug 22, 2022 · 0 comments
Labels
A-meta Not about any part of Miri per se, but about shaping the environment to make something in/with Miri C-enhancement Category: a PR with an enhancement or an issue tracking an accepted enhancement

Comments

@RalfJung
Copy link
Member

Currently, overflow checks are disabled in the builds we distribute via rustup. To mitigate this we have the clippy::integer_arithmetic lint enabled in parts of Miri (since #2441), but that is mostly just a verbose way of doing overflow checks by hand. It'd be better if we could find some way to enable overflow checks in the distributed builds, but I am not sure how to do that -- we'd basically want them to be enabled only for the Miri lib crate, but cargo only supports enabling them for all crates involved in the build.

@RalfJung RalfJung added A-meta Not about any part of Miri per se, but about shaping the environment to make something in/with Miri C-enhancement Category: a PR with an enhancement or an issue tracking an accepted enhancement and removed A-meta Not about any part of Miri per se, but about shaping the environment to make something in/with Miri labels Aug 22, 2022
@RalfJung RalfJung added the A-meta Not about any part of Miri per se, but about shaping the environment to make something in/with Miri label Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-meta Not about any part of Miri per se, but about shaping the environment to make something in/with Miri C-enhancement Category: a PR with an enhancement or an issue tracking an accepted enhancement
Projects
None yet
Development

No branches or pull requests

1 participant