Implement Clone for SubCaptureMatches #689
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clonable iterators are useful when writing code that is generic over iterators that needs to be able to iterate twice.
BurntSushi
pushed a commit
that referenced
this pull request
Oct 11, 2020
This is useful in a generic context when you want to iterate over something twice. There's not much reason to not do it at least. Closes #689
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to BurntSushi/rust-csv#204, consider this a proposal more than anything else. Not sure if there are edge cases I haven't considered. I poked around but didn't see any former discussions/issues about this.
Clonable iterators are useful when writing code that is generic over
iterators that needs to be able to iterate twice.