Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rfcbot should see a merge of a pr as accepting it. #101

Closed
bjorn3 opened this issue Oct 19, 2016 · 3 comments
Closed

Rfcbot should see a merge of a pr as accepting it. #101

bjorn3 opened this issue Oct 19, 2016 · 3 comments
Labels

Comments

@bjorn3
Copy link
Member

bjorn3 commented Oct 19, 2016

See rust-lang/rust#36707 (bottom) for a example of the current behaviour.

@anp
Copy link
Member

anp commented Oct 19, 2016

I don't see much of a practical difference in terms of user interactions, aside from the cancellation comment (which could be removed in this case).

@aturon do you think it'd be better to keep the database entries around but close them off when an issue/PR is closed before FCP starts?

@aturon
Copy link
Member

aturon commented Oct 19, 2016

It'd be nice to avoid the cancellation comment, which will confuse people. I think that once a PR is closed/merged, the bot shouldn't leave any further comments.

@aturon aturon added the rfcbot label Oct 22, 2016
@anp
Copy link
Member

anp commented Oct 25, 2016

Fixed by 26f8e42 -- won't be deployed until I get the other batch of changes online, though.

@anp anp closed this as completed Oct 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants