Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FCP dashboard looks to be out of sync #107

Closed
aturon opened this issue Nov 7, 2016 · 5 comments
Closed

FCP dashboard looks to be out of sync #107

aturon opened this issue Nov 7, 2016 · 5 comments

Comments

@aturon
Copy link
Member

aturon commented Nov 7, 2016

Example: @sfackler has checked off rust-lang/rust#23755 but it still shows up on his dashboard.
@anp
Copy link
Member

anp commented Nov 8, 2016

Yeah it looks like things are quite out of sync. Taking a look.

@anp
Copy link
Member

anp commented Nov 8, 2016

Looks like there's a row missing in the database somewhere, returning an Err, and the whole FCP process is getting early returned by a serious of try!'s most likely. I will be able to dig into this further later tonight hopefully.

@aturon
Copy link
Member Author

aturon commented Nov 10, 2016

Any news on this, or maybe pointers to the code you think is going wrong?

@anp
Copy link
Member

anp commented Nov 10, 2016

Hey! I just got back from travelling. I think I'll be able to look again in the morning.

@anp
Copy link
Member

anp commented Nov 11, 2016

Alright, finally got around to this!

I added finer-grained error handling to the rfcbot stuff. Going to keep a close eye on it to see where that error may have originated from. For the time being it's been able to catch up on FCPs as far as I can tell.

@anp anp closed this as completed Nov 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aturon @anp