Mutable binding syntax highlighting flashes too often when typing

[BlackHoleFox]

I'm not sure when this started since I only started to notice it and get annoyed by it earlier yesterday but as of recently the syntax highlighting that underlines mutable bindings in VSCode has been persistently annoying. Everytime I start and stop typing, every mutable binding on my screen briefly loses its underlining. This occurs even if I'm not changing any actual code

Even weirder, it only really happens when I type two characters consecutively. Typing one, pausing, then typing another doesn't trigger it. See below:

Let me know if there's anything else I can provide, but here are my relevant versions:

rust-analyzer version: a824768 2021-11-04 nightly
vscode-insiders version: 1.62.0-insider b3318bc0524af3d74034b8bb8a64df0ccf35549a
OS: Win 10

[Veykril]

Can't reproduce this myself(vscode 1.16.1), this seems like either a VSCode bug to me, or maybe another extension of yours is interfering with things.

[jhgg]

I can reproduce this in a larger workspace. It appears to be related to when salsa queries get cancelled and it sends the content modified error back to vscode. Not sure if the bug is in vscode's end or not however.

It affects all semantic tokens, not only mutable (which is the obvious one for most people who don't have semantic token customizations.)

Maybe regression on microsoft/vscode-languageserver-node#576 ?

[thomcc]

I have this issue, except it happens for the color of documentation comments (flickering between the doc-comment and plain-comment color when I type). I'm assuming it's the same, since they're both related to semantic highlighting.

I have some issues with photo-sensitivity triggered by flashing, and when editing a lot of documentation the rapid flickering this caused felt like it was starting to trigger it. I'll find a way to work around it, but a fix would be greatly appreciated, since it could be a bigger issue for someone more sensitive to this than I am.

EDIT: actually, it seems like sometimes it's pretty much all the semantic highlighting in the file that flickers. Other times it's not as bad. Either way, it's very unfortunate :(. At least turning off semantic highlighting seems to have worked.

[Veykril]

Okay I just tested it with the insiders build of VSCode(1.63.0-insider), and I can reproduce it there. So this seems to be a regression on their part as I can't reproduce it on 1.16.1.

[Veykril]

Opened an issue on the vscode repo microsoft/vscode#136540

[Veykril]

The issue has been fixed upstream, so I assume the next insiders build should ship with it.