Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upcoming proc-macro ABI breakage #12806

Closed
mystor opened this issue Jul 18, 2022 · 1 comment
Closed

Upcoming proc-macro ABI breakage #12806

mystor opened this issue Jul 18, 2022 · 1 comment
Labels
A-proc-macro proc macro

Comments

@mystor
Copy link
Contributor

mystor commented Jul 18, 2022

The changes in rust-lang/rust#98189 were just approved, and are likely to land soon, which will change the unstable proc-macro bridge ABI. I figured I'd file a bug to let you folks know about the changes earlier, in case it could help us reduce how long nightly+rust-analyzer remains broken for.

After these patches land I don't currently have any more patches posted which will break the ABI, though I'm experimenting with some other performance improvements and tweaks locally which will also lead to ABI breakage.
@bjorn3 bjorn3 added the A-proc-macro proc macro label Jul 18, 2022
This was referenced Jul 19, 2022
Closed
Closed
@TheButlah TheButlah mentioned this issue Jul 27, 2022
Closed
@fasterthanlime
Copy link
Contributor

This can probably be closed as per #12803 (comment)

(It'll be "fixed for good" on monday, but there is a version of proc-macro-srv that supports the latest ABI now).

@Veykril Veykril closed this as completed Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-proc-macro proc macro
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mystor @Veykril @fasterthanlime @bjorn3