Can't build stylo in FF 56.x #1087

tpgxyz · 2017-10-17T17:31:29Z

Bindgen Invocation

I'm trying to build FF 56.0.1 with rust-1.21.0.

Full logs can be found here http://file-store.openmandriva.org/api/v1/file_stores/1e85cf22a732ff76c55f52625dfab10fbfcaac23.log?show=true

error: failed to run custom build command for style v0.0.1 (file:///builddir/build/BUILD/firefox-56.0.1/servo/components/style)


/builddir/build/BUILD/firefox-56.0.1/obj/dist/include/nsCSSFontFaceRule.h:137:38: warning: offset of on non-standard-layout type 'nsCSSFontFaceRule' [-Winvalid-offsetof], err: false
/builddir/build/BUILD/firefox-56.0.1/obj/dist/include/nsCSSFontFaceRule.h:144:44: warning: offset of on non-standard-layout type 'nsCSSFontFaceRule' [-Winvalid-offsetof], err: false
/builddir/build/BUILD/firefox-56.0.1/obj/dist/include/nsStyleContext.h:76:15: warning: inline function 'nsStyleContext::Release' is not defined [-Wundefined-inline], err: false
--- stderr
thread '<unnamed>' panicked at 'Non floating-type complex?', /builddir/build/BUILD/firefox-56.0.1/third_party/rust/bindgen/src/ir/context.rs:1409:25
stack backtrace:
   0: std::sys::imp::backtrace::tracing::imp::unwind_backtrace
             at src/libstd/sys/unix/backtrace/tracing/gcc_s.rs:49
   1: std::sys_common::backtrace::_print
             at src/libstd/sys_common/backtrace.rs:71
   2: std::panicking::default_hook::{{closure}}
             at src/libstd/sys_common/backtrace.rs:60
             at src/libstd/panicking.rs:381
   3: std::panicking::default_hook
             at src/libstd/panicking.rs:397
   4: std::panicking::rust_panic_with_hook
             at src/libstd/panicking.rs:611
   5: std::panicking::begin_panic
   6: bindgen::ir::context::BindgenContext::builtin_or_resolved_ty
   7: <bindgen::ir::item::Item as bindgen::parse::ClangItemParser>::from_ty_or_ref_with_id
   8: bindgen::ir::ty::Type::from_clang_ty
   9: <bindgen::ir::item::Item as bindgen::parse::ClangItemParser>::from_ty_with_id
  10: <bindgen::ir::item::Item as bindgen::parse::ClangItemParser>::parse
  11: bindgen::clang::visit_children
  12: <unknown>
  13: <unknown>
  14: <unknown>
  15: <unknown>
  16: clang_visitChildren
  17: clang_sys::clang_visitChildren
  18: bindgen::Bindings::generate
  19: bindgen::Builder::generate
  20: build_script_build::build_gecko::bindings::write_binding_file
  21: build_script_build::build_gecko::bindings::generate_bindings
  22: __rust_maybe_catch_panic
             at src/libpanic_unwind/lib.rs:99
  23: <F as alloc::boxed::FnBox<A>>::call_box
  24: std::sys::imp::thread::Thread::new::thread_start
             at /builddir/build/BUILD/rustc-1.21.0-src/src/liballoc/boxed.rs:692
             at src/libstd/sys_common/thread.rs:21
             at src/libstd/sys/unix/thread.rs:84
  25: start_thread
  26: __GI___clone
thread '<unnamed>' panicked at 'Non floating-type complex?', /builddir/build/BUILD/firefox-56.0.1/third_party/rust/bindgen/src/ir/context.rs:1409:25
stack backtrace:
   0: std::sys::imp::backtrace::tracing::imp::unwind_backtrace
             at src/libstd/sys/unix/backtrace/tracing/gcc_s.rs:49
   1: std::sys_common::backtrace::_print
             at src/libstd/sys_common/backtrace.rs:71
   2: std::panicking::default_hook::{{closure}}
             at src/libstd/sys_common/backtrace.rs:60
             at src/libstd/panicking.rs:381
   3: std::panicking::default_hook
             at src/libstd/panicking.rs:397
   4: std::panicking::rust_panic_with_hook
             at src/libstd/panicking.rs:611
   5: std::panicking::begin_panic
   6: bindgen::ir::context::BindgenContext::builtin_or_resolved_ty
   7: <bindgen::ir::item::Item as bindgen::parse::ClangItemParser>::from_ty_or_ref_with_id
   8: bindgen::ir::ty::Type::from_clang_ty
   9: <bindgen::ir::item::Item as bindgen::parse::ClangItemParser>::from_ty_with_id
  10: <bindgen::ir::item::Item as bindgen::parse::ClangItemParser>::parse
  11: bindgen::clang::visit_children
  12: <unknown>
  13: <unknown>
  14: <unknown>
  15: <unknown>
  16: clang_visitChildren
  17: clang_sys::clang_visitChildren
  18: bindgen::clang::visit_children
  19: <unknown>
  20: <unknown>
  21: <unknown>
  22: <unknown>
  23: clang_visitChildren
  24: clang_sys::clang_visitChildren
  25: bindgen::Bindings::generate
  26: bindgen::Builder::generate
  27: build_script_build::build_gecko::bindings::write_binding_file
  28: build_script_build::build_gecko::bindings::generate_structs
  29: __rust_maybe_catch_panic
             at src/libpanic_unwind/lib.rs:99
  30: <F as alloc::boxed::FnBox<A>>::call_box
  31: std::sys::imp::thread::Thread::new::thread_start
             at /builddir/build/BUILD/rustc-1.21.0-src/src/liballoc/boxed.rs:692
             at src/libstd/sys_common/thread.rs:21
             at src/libstd/sys/unix/thread.rs:84
  32: start_thread
  33: __GI___clone
thread '<unnamed>' panicked at 'Non floating-type complex?', /builddir/build/BUILD/firefox-56.0.1/third_party/rust/bindgen/src/ir/context.rs:1409:25
stack backtrace:
   0: std::sys::imp::backtrace::tracing::imp::unwind_backtrace
             at src/libstd/sys/unix/backtrace/tracing/gcc_s.rs:49
   1: std::sys_common::backtrace::_print
             at src/libstd/sys_common/backtrace.rs:71
   2: std::panicking::default_hook::{{closure}}
             at src/libstd/sys_common/backtrace.rs:60
             at src/libstd/panicking.rs:381
   3: std::panicking::default_hook
             at src/libstd/panicking.rs:397
   4: std::panicking::rust_panic_with_hook
             at src/libstd/panicking.rs:611
   5: std::panicking::begin_panic
   6: bindgen::ir::context::BindgenContext::builtin_or_resolved_ty
   7: <bindgen::ir::item::Item as bindgen::parse::ClangItemParser>::from_ty_or_ref_with_id
   8: bindgen::ir::ty::Type::from_clang_ty
   9: <bindgen::ir::item::Item as bindgen::parse::ClangItemParser>::from_ty_with_id
  10: <bindgen::ir::item::Item as bindgen::parse::ClangItemParser>::parse
  11: bindgen::clang::visit_children
  12: <unknown>
  13: <unknown>
  14: <unknown>
  15: <unknown>
  16: clang_visitChildren
  17: clang_sys::clang_visitChildren
  18: bindgen::clang::visit_children
  19: <unknown>
  20: <unknown>
  21: <unknown>
  22: <unknown>
  23: clang_visitChildren
  24: clang_sys::clang_visitChildren
  25: bindgen::Bindings::generate
  26: bindgen::Builder::generate
  27: build_script_build::build_gecko::bindings::write_binding_file
  28: build_script_build::build_gecko::bindings::generate_structs
  29: __rust_maybe_catch_panic
             at src/libpanic_unwind/lib.rs:99
  30: <F as alloc::boxed::FnBox<A>>::call_box
  31: std::sys::imp::thread::Thread::new::thread_start
             at /builddir/build/BUILD/rustc-1.21.0-src/src/liballoc/boxed.rs:692
             at src/libstd/sys_common/thread.rs:21
             at src/libstd/sys/unix/thread.rs:84
  32: start_thread
  33: __GI___clone
thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: Any', src/libcore/result.rs:906:4
stack backtrace:
   0: std::sys::imp::backtrace::tracing::imp::unwind_backtrace
             at src/libstd/sys/unix/backtrace/tracing/gcc_s.rs:49
   1: std::sys_common::backtrace::_print
             at src/libstd/sys_common/backtrace.rs:71
   2: std::panicking::default_hook::{{closure}}
             at src/libstd/sys_common/backtrace.rs:60
             at src/libstd/panicking.rs:381
   3: std::panicking::default_hook
             at src/libstd/panicking.rs:397
   4: std::panicking::rust_panic_with_hook
             at src/libstd/panicking.rs:611
   5: std::panicking::begin_panic
             at src/libstd/panicking.rs:572
   6: std::panicking::begin_panic_fmt
             at src/libstd/panicking.rs:522
   7: rust_begin_unwind
             at src/libstd/panicking.rs:498
   8: core::panicking::panic_fmt
             at src/libcore/panicking.rs:71
   9: core::result::unwrap_failed
  10: build_script_build::main
  11: __rust_maybe_catch_panic
             at src/libpanic_unwind/lib.rs:99
  12: std::rt::lang_start
             at src/libstd/panicking.rs:459
             at src/libstd/panic.rs:361
             at src/libstd/rt.rs:61
  13: __libc_start_main
  14: _start
             at ../sysdeps/x86_64/start.S:120

Expected Results

Firefox compiles

The text was updated successfully, but these errors were encountered:

emilio · 2017-10-17T17:32:13Z

Which version of bindgen is FF56 using?

tpgxyz · 2017-10-17T20:59:55Z

@emilio In logs you can see Compiling bindgen v0.29.0

tpgxyz · 2017-10-23T13:48:54Z

Ping anyone ?

fitzgen · 2017-10-23T17:16:29Z

Any chance you could use builder.dump_preprocessed_input() in servo's components/style/build_gecko.rs and then run creduce until we have a minimal test case? https://github.com/rust-lang-nursery/rust-bindgen/blob/master/CONTRIBUTING.md#using-creduce-to-minimize-test-cases

tpgxyz · 2017-10-26T09:50:25Z

@fitzgen Sorry to say that, but i don't know rust, and all i can do is to run build in our build environement.

I can provide any debug you tell me to add to .spec file when building RPM

tpgxyz · 2018-01-12T16:04:48Z

Still the same issue.
I can't compile firefox 57.x with stylo enabled.

https://abf.openmandriva.org/build_lists/145077

emilio · 2018-01-13T11:03:20Z

thread '' panicked at 'Non floating-type complex?', /builddir/build/BUILD/firefox-57.0.4/third_party/rust/bindgen-0.29.1/src/ir/context.rs:1409:25

That is an interesting error.

@tpgxyz which version of libclang is this? Also, can you try to build nightly from https://hg.mozilla.org/mozilla-central/? That has a more up-to-date bindgen.

tpgxyz · 2018-01-13T12:28:19Z

@emilio I'm running LLVM 5.0.0

Well I want to compile officially released latest firefox not a nightly build, as my district's users does not want to experiment that much.

emilio · 2018-01-14T17:55:22Z

Sure, I just wanted to know whether an updated bindgen / FF version worked in the same environment, which may be helpful. In particular, there are some bugs fixed in the way bindgen interacted with system dependencies on Firefox, like https://bugzilla.mozilla.org/show_bug.cgi?id=1341234.

tpgxyz · 2018-01-16T21:32:13Z

@emilio I've appiled these patches and unfortunately FF still does not build with stylo enabled.

https://abf.openmandriva.org/build_lists/145577

emilio · 2018-01-16T22:14:35Z

If you could apply this patch to the rust-bindgen tree it'd be helpful to figure that out.

Alternatively, applying something like the following, and getting the __bindgen.ii file from the builder would also be amazing:

diff --git a/servo/components/style/build_gecko.rs b/servo/components/style/build_gecko.rs
index 1bef36f8b289..7635f6627ef6 100644
--- a/servo/components/style/build_gecko.rs
+++ b/servo/components/style/build_gecko.rs
@@ -275,6 +275,7 @@ mod bindings {
                 return;
             }
         }
+        builder.dump_preprocessed_input().expect("Couldn't dump input");
         let command_line_opts = builder.command_line_flags();
         let result = builder.generate();
         let mut result = match result {
@@ -565,7 +566,7 @@ mod bindings {
         use std::thread;
         macro_rules! run_tasks {
             ($($task:expr,)+) => {
-                if setup_logging() {
+                if true || setup_logging() {
                     $($task;)+
                 } else {
                     let threads = vec![$( thread::spawn(|| $task) ),+];

cris-b · 2018-01-17T09:27:18Z

Looks like its Float128, modifying to:

            let float_kind = match float_type.kind() {
                CXType_Float => FloatKind::Float,
                CXType_Double => FloatKind::Double,
                CXType_LongDouble => FloatKind::LongDouble,
                CXType_Float128 => FloatKind::Float128,
                _ => panic!("Non floating-type complex? {:?}, {:?}", ty, float_type),
            };

makes it build ok - i've no idea if this is correct though.

attached the file requested.
__bindgen.ii.txt

emilio · 2018-01-17T13:33:49Z

Yeah, that patch looks good to me. Want to submit a PR?

Tests for this live in tests/headers/complex.h, though I'm not sure we can test this one because rust still doesn't support 128-bit aligned values.

tpgxyz · 2018-01-18T09:47:39Z

@cris-b Excellent catch. Many thanks for finding issue.

emilio · 2018-01-23T01:09:19Z

I updated bindgen with this fix on mozilla-central in https://bugzilla.mozilla.org/show_bug.cgi?id=1432134

fitzgen added I-needs-reduced-test-case I-panic I-Stylo labels Oct 23, 2017

emilio mentioned this issue Jan 16, 2018

ir: Give more info for the non-floating type complex type message. #1222

Closed

bors-servo closed this as completed in ea603ce Jan 19, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Can't build stylo in FF 56.x #1087

Can't build stylo in FF 56.x #1087

tpgxyz commented Oct 17, 2017 •

edited

Loading

emilio commented Oct 17, 2017

tpgxyz commented Oct 17, 2017

tpgxyz commented Oct 23, 2017

fitzgen commented Oct 23, 2017

tpgxyz commented Oct 26, 2017

tpgxyz commented Jan 12, 2018

emilio commented Jan 13, 2018

tpgxyz commented Jan 13, 2018 •

edited

Loading

emilio commented Jan 14, 2018

tpgxyz commented Jan 16, 2018

emilio commented Jan 16, 2018

cris-b commented Jan 17, 2018 •

edited

Loading

emilio commented Jan 17, 2018

tpgxyz commented Jan 18, 2018

emilio commented Jan 23, 2018

Can't build stylo in FF 56.x #1087

Can't build stylo in FF 56.x #1087

Comments

tpgxyz commented Oct 17, 2017 • edited Loading

Bindgen Invocation

Expected Results

emilio commented Oct 17, 2017

tpgxyz commented Oct 17, 2017

tpgxyz commented Oct 23, 2017

fitzgen commented Oct 23, 2017

tpgxyz commented Oct 26, 2017

tpgxyz commented Jan 12, 2018

emilio commented Jan 13, 2018

tpgxyz commented Jan 13, 2018 • edited Loading

emilio commented Jan 14, 2018

tpgxyz commented Jan 16, 2018

emilio commented Jan 16, 2018

cris-b commented Jan 17, 2018 • edited Loading

emilio commented Jan 17, 2018

tpgxyz commented Jan 18, 2018

emilio commented Jan 23, 2018

tpgxyz commented Oct 17, 2017 •

edited

Loading

tpgxyz commented Jan 13, 2018 •

edited

Loading

cris-b commented Jan 17, 2018 •

edited

Loading