Added pointer arrays option #1564
Conversation
|
Added CLI support and tests for with and without the flag |
|
btw, I see that it uses |
tests/headers/array_pointers.h
Outdated
| @@ -0,0 +1,4 @@ | |||
|
|
|||
| int test_fn(float a, int arr[20]); | |||
There was a problem hiding this comment.
This should also add a test with typedefs.
There was a problem hiding this comment.
The problem with typedefs is that they are treated as regular arrays for some reason, I'm not sure if it's the right behavior or not. this means that this is kind of already the default thing but without a pointer:
typedef int arr1[20];
typedef int* arr2[20];
typedef int (*arr3)[20];
pub type arr1 = [::std::os::raw::c_int; 20usize];
pub type arr2 = [*mut ::std::os::raw::c_int; 20usize];
pub type arr3 = *mut [::std::os::raw::c_int; 20usize];
There was a problem hiding this comment.
Those typedefs look correct to me. What I meant is that something like: void foo(arr1 a) generates sane code. It should generate an in pointer without your patch, which is the right thing, but it should generate a: *mut arr1 with your patch, not just a: arr1.
There was a problem hiding this comment.
Added. tell me if you're happy with the tests.
|
c_floats are always f32: https://doc.rust-lang.org/std/os/raw/type.c_float.html But sure, it should probably be changed. Probably a different patch though. |
| t.to_rust_ty_or_opaque(ctx, &()) | ||
| }; | ||
| stream.to_ptr(ctx.resolve_type(t).is_const()) | ||
| } |
There was a problem hiding this comment.
This is much more concise than the initial version :)
src/codegen/mod.rs
Outdated
| .to_ptr(ctx.resolve_type(t).is_const()) | ||
| }, | ||
| let stream = if ctx.options().array_pointers_in_arguments { | ||
| (*arg_ty).to_rust_ty_or_opaque(ctx, &arg_item) |
There was a problem hiding this comment.
Do you need the explicit dereference?
There was a problem hiding this comment.
Weird. I did this because it complained but now it works without
|
Could you publish a new version? |
|
Done :) |
|
Thanks! :) |
This adds an option to expose
arr[size]as*mut [T; size]instead of*mut TResolves #1561