Upgrade 'which' to remove indirect dependency on 'failure'. #1625
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While using
bindgen
I noticed it brought along thefailure
crate, but only through thewhich
dependency, and bindgen not even using it itself.In an effort to remove the dependencies I don't need in my project, I therefore submitted a PR to
which
(harryfei/which-rs#14) to enable dependent crates to not bring infailure
and its dependencies, which is what this PR is about! 😃This PR upgrades
which
to version 3.0 and disables its default features, effectively removing thefailure
dependency frombindgen
as well as its sub-dependencies:backtrace
,backtrace-sys
, andrustc-demangle
. Sincebingen
uses none of them, this is only a dependency change, there is no code change inbindgen
itself.I also noticed #1615 a little too late, and while the issue is similar I believe those two PRs are actually orthogonal: #1615 allows to remove
which
for the users who don't need to findrustfmt
(or use it altogether, which is actually my use-case in the end 🤷♂️ ), while this PR makes sure to removefailure
and its dependencies across the board, regardless of the user's usage ofrustfmt
.