-
Notifications
You must be signed in to change notification settings - Fork 1.6k
/
fmt.rs
416 lines (380 loc) · 13 KB
/
fmt.rs
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
use crate::utils::clippy_project_root;
use itertools::Itertools;
use rustc_lexer::{TokenKind, tokenize};
use shell_escape::escape;
use std::ffi::{OsStr, OsString};
use std::ops::ControlFlow;
use std::path::{Path, PathBuf};
use std::process::{self, Command, Stdio};
use std::{fs, io};
use walkdir::WalkDir;
pub enum Error {
CommandFailed(String, String),
Io(io::Error),
RustfmtNotInstalled,
WalkDir(walkdir::Error),
IntellijSetupActive,
Parse(PathBuf, usize, String),
CheckFailed,
}
impl From<io::Error> for Error {
fn from(error: io::Error) -> Self {
Self::Io(error)
}
}
impl From<walkdir::Error> for Error {
fn from(error: walkdir::Error) -> Self {
Self::WalkDir(error)
}
}
impl Error {
fn display(&self) {
match self {
Self::CheckFailed => {
eprintln!("Formatting check failed!\nRun `cargo dev fmt` to update.");
},
Self::CommandFailed(command, stderr) => {
eprintln!("error: command `{command}` failed!\nstderr: {stderr}");
},
Self::Io(err) => {
eprintln!("error: {err}");
},
Self::RustfmtNotInstalled => {
eprintln!("error: rustfmt nightly is not installed.");
},
Self::WalkDir(err) => {
eprintln!("error: {err}");
},
Self::IntellijSetupActive => {
eprintln!(
"error: a local rustc repo is enabled as path dependency via `cargo dev setup intellij`.\n\
Not formatting because that would format the local repo as well!\n\
Please revert the changes to `Cargo.toml`s with `cargo dev remove intellij`."
);
},
Self::Parse(path, line, msg) => {
eprintln!("error parsing `{}:{line}`: {msg}", path.display());
},
}
}
}
struct FmtContext {
check: bool,
verbose: bool,
rustfmt_path: String,
}
struct ClippyConf<'a> {
name: &'a str,
attrs: &'a str,
lints: Vec<&'a str>,
field: &'a str,
}
fn offset_to_line(text: &str, offset: usize) -> usize {
match text.split('\n').try_fold((1usize, 0usize), |(line, pos), s| {
let pos = pos + s.len() + 1;
if pos > offset {
ControlFlow::Break(line)
} else {
ControlFlow::Continue((line + 1, pos))
}
}) {
ControlFlow::Break(x) | ControlFlow::Continue((x, _)) => x,
}
}
/// Formats the configuration list in `clippy_config/src/conf.rs`
#[expect(clippy::too_many_lines)]
fn fmt_conf(check: bool) -> Result<(), Error> {
#[derive(Clone, Copy)]
enum State {
Start,
Docs,
Pound,
OpenBracket,
Attr(u32),
Lints,
EndLints,
Field,
}
let path: PathBuf = [
clippy_project_root().as_path(),
"clippy_config".as_ref(),
"src".as_ref(),
"conf.rs".as_ref(),
]
.into_iter()
.collect();
let text = fs::read_to_string(&path)?;
let (pre, conf) = text
.split_once("define_Conf! {\n")
.expect("can't find config definition");
let (conf, post) = conf.split_once("\n}\n").expect("can't find config definition");
let conf_offset = pre.len() + 15;
let mut pos = 0u32;
let mut attrs_start = 0;
let mut attrs_end = 0;
let mut field_start = 0;
let mut lints = Vec::new();
let mut name = "";
let mut fields = Vec::new();
let mut state = State::Start;
for (i, t) in tokenize(conf)
.map(|x| {
let start = pos;
pos += x.len;
(start as usize, x)
})
.filter(|(_, t)| !matches!(t.kind, TokenKind::Whitespace))
{
match (state, t.kind) {
(State::Start, TokenKind::LineComment { doc_style: Some(_) }) => {
attrs_start = i;
attrs_end = i + t.len as usize;
state = State::Docs;
},
(State::Start, TokenKind::Pound) => {
attrs_start = i;
attrs_end = i;
state = State::Pound;
},
(State::Docs, TokenKind::LineComment { doc_style: Some(_) }) => attrs_end = i + t.len as usize,
(State::Docs, TokenKind::Pound) => state = State::Pound,
(State::Pound, TokenKind::OpenBracket) => state = State::OpenBracket,
(State::OpenBracket, TokenKind::Ident) => {
state = if conf[i..i + t.len as usize] == *"lints" {
State::Lints
} else {
State::Attr(0)
};
},
(State::Attr(0), TokenKind::CloseBracket) => {
attrs_end = i + 1;
state = State::Docs;
},
(State::Attr(x), TokenKind::OpenParen | TokenKind::OpenBracket | TokenKind::OpenBrace) => {
state = State::Attr(x + 1);
},
(State::Attr(x), TokenKind::CloseParen | TokenKind::CloseBracket | TokenKind::CloseBrace) => {
state = State::Attr(x - 1);
},
(State::Lints, TokenKind::Ident) => lints.push(&conf[i..i + t.len as usize]),
(State::Lints, TokenKind::CloseBracket) => state = State::EndLints,
(State::EndLints | State::Docs, TokenKind::Ident) => {
field_start = i;
name = &conf[i..i + t.len as usize];
state = State::Field;
},
(State::Field, TokenKind::LineComment { doc_style: Some(_) }) => {
#[expect(clippy::drain_collect)]
fields.push(ClippyConf {
name,
lints: lints.drain(..).collect(),
attrs: &conf[attrs_start..attrs_end],
field: conf[field_start..i].trim_end(),
});
attrs_start = i;
attrs_end = i + t.len as usize;
state = State::Docs;
},
(State::Field, TokenKind::Pound) => {
#[expect(clippy::drain_collect)]
fields.push(ClippyConf {
name,
lints: lints.drain(..).collect(),
attrs: &conf[attrs_start..attrs_end],
field: conf[field_start..i].trim_end(),
});
attrs_start = i;
attrs_end = i;
state = State::Pound;
},
(State::Field | State::Attr(_), _)
| (State::Lints, TokenKind::Comma | TokenKind::OpenParen | TokenKind::CloseParen) => {},
_ => {
return Err(Error::Parse(
path,
offset_to_line(&text, conf_offset + i),
format!("unexpected token `{}`", &conf[i..i + t.len as usize]),
));
},
}
}
if !matches!(state, State::Field) {
return Err(Error::Parse(
path,
offset_to_line(&text, conf_offset + conf.len()),
"incomplete field".into(),
));
}
fields.push(ClippyConf {
name,
lints,
attrs: &conf[attrs_start..attrs_end],
field: conf[field_start..].trim_end(),
});
for field in &mut fields {
field.lints.sort_unstable();
}
fields.sort_by_key(|x| x.name);
let new_text = format!(
"{pre}define_Conf! {{\n{}}}\n{post}",
fields.iter().format_with("", |field, f| {
if field.lints.is_empty() {
f(&format_args!(" {}\n {}\n", field.attrs, field.field))
} else if field.lints.iter().map(|x| x.len() + 2).sum::<usize>() < 120 - 14 {
f(&format_args!(
" {}\n #[lints({})]\n {}\n",
field.attrs,
field.lints.iter().join(", "),
field.field,
))
} else {
f(&format_args!(
" {}\n #[lints({}\n )]\n {}\n",
field.attrs,
field
.lints
.iter()
.format_with("", |x, f| f(&format_args!("\n {x},"))),
field.field,
))
}
})
);
if text != new_text {
if check {
return Err(Error::CheckFailed);
}
fs::write(&path, new_text.as_bytes())?;
}
Ok(())
}
fn run_rustfmt(context: &FmtContext) -> Result<(), Error> {
let project_root = clippy_project_root();
// if we added a local rustc repo as path dependency to clippy for rust analyzer, we do NOT want to
// format because rustfmt would also format the entire rustc repo as it is a local
// dependency
if fs::read_to_string(project_root.join("Cargo.toml"))
.expect("Failed to read clippy Cargo.toml")
.contains("[target.'cfg(NOT_A_PLATFORM)'.dependencies]")
{
return Err(Error::IntellijSetupActive);
}
check_for_rustfmt(context)?;
cargo_fmt(context, project_root.as_path())?;
cargo_fmt(context, &project_root.join("clippy_dev"))?;
cargo_fmt(context, &project_root.join("rustc_tools_util"))?;
cargo_fmt(context, &project_root.join("lintcheck"))?;
let chunks = WalkDir::new(project_root.join("tests"))
.into_iter()
.filter_map(|entry| {
let entry = entry.expect("failed to find tests");
let path = entry.path();
if path.extension() != Some("rs".as_ref()) || entry.file_name() == "ice-3891.rs" {
None
} else {
Some(entry.into_path().into_os_string())
}
})
.chunks(250);
for chunk in &chunks {
rustfmt(context, chunk)?;
}
Ok(())
}
// the "main" function of cargo dev fmt
pub fn run(check: bool, verbose: bool) {
let output = Command::new("rustup")
.args(["which", "rustfmt"])
.stderr(Stdio::inherit())
.output()
.expect("error running `rustup which rustfmt`");
if !output.status.success() {
eprintln!("`rustup which rustfmt` did not execute successfully");
process::exit(1);
}
let mut rustfmt_path = String::from_utf8(output.stdout).expect("invalid rustfmt path");
rustfmt_path.truncate(rustfmt_path.trim_end().len());
let context = FmtContext {
check,
verbose,
rustfmt_path,
};
if let Err(e) = run_rustfmt(&context).and_then(|()| fmt_conf(check)) {
e.display();
process::exit(1);
}
}
fn format_command(program: impl AsRef<OsStr>, dir: impl AsRef<Path>, args: &[impl AsRef<OsStr>]) -> String {
let arg_display: Vec<_> = args.iter().map(|a| escape(a.as_ref().to_string_lossy())).collect();
format!(
"cd {} && {} {}",
escape(dir.as_ref().to_string_lossy()),
escape(program.as_ref().to_string_lossy()),
arg_display.join(" ")
)
}
fn exec_fmt_command(
context: &FmtContext,
program: impl AsRef<OsStr>,
dir: impl AsRef<Path>,
args: &[impl AsRef<OsStr>],
) -> Result<(), Error> {
if context.verbose {
println!("{}", format_command(&program, &dir, args));
}
let output = Command::new(&program)
.env("RUSTFMT", &context.rustfmt_path)
.current_dir(&dir)
.args(args.iter())
.output()
.unwrap();
let success = output.status.success();
match (context.check, success) {
(_, true) => Ok(()),
(true, false) => Err(Error::CheckFailed),
(false, false) => {
let stderr = std::str::from_utf8(&output.stderr).unwrap_or("");
Err(Error::CommandFailed(
format_command(&program, &dir, args),
String::from(stderr),
))
},
}
}
fn cargo_fmt(context: &FmtContext, path: &Path) -> Result<(), Error> {
let mut args = vec!["fmt", "--all"];
if context.check {
args.push("--check");
}
exec_fmt_command(context, "cargo", path, &args)
}
fn check_for_rustfmt(context: &FmtContext) -> Result<(), Error> {
let program = "rustfmt";
let dir = std::env::current_dir()?;
let args = &["--version"];
if context.verbose {
println!("{}", format_command(program, &dir, args));
}
let output = Command::new(program).current_dir(&dir).args(args.iter()).output()?;
if output.status.success() {
Ok(())
} else if std::str::from_utf8(&output.stderr)
.unwrap_or("")
.starts_with("error: 'rustfmt' is not installed")
{
Err(Error::RustfmtNotInstalled)
} else {
Err(Error::CommandFailed(
format_command(program, &dir, args),
std::str::from_utf8(&output.stderr).unwrap_or("").to_string(),
))
}
}
fn rustfmt(context: &FmtContext, paths: impl Iterator<Item = OsString>) -> Result<(), Error> {
let mut args = Vec::new();
if context.check {
args.push(OsString::from("--check"));
}
args.extend(paths);
exec_fmt_command(context, &context.rustfmt_path, std::env::current_dir()?, &args)
}