From b36d7a0c61b26ed19511de63aab7517fad1a9109 Mon Sep 17 00:00:00 2001 From: Michael Wright Date: Thu, 6 Jun 2019 07:12:12 +0200 Subject: [PATCH] Remove `to_string()`s from CompilerLintFunctions --- clippy_lints/src/utils/internal_lints.rs | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/clippy_lints/src/utils/internal_lints.rs b/clippy_lints/src/utils/internal_lints.rs index e8b2743bcf47..6b91ac8cc99e 100644 --- a/clippy_lints/src/utils/internal_lints.rs +++ b/clippy_lints/src/utils/internal_lints.rs @@ -213,17 +213,17 @@ impl<'a, 'tcx: 'a> Visitor<'tcx> for LintCollector<'a, 'tcx> { #[derive(Clone, Default)] pub struct CompilerLintFunctions { - map: FxHashMap, + map: FxHashMap<&'static str, &'static str>, } impl CompilerLintFunctions { pub fn new() -> Self { let mut map = FxHashMap::default(); - map.insert("span_lint".to_string(), "utils::span_lint".to_string()); - map.insert("struct_span_lint".to_string(), "utils::span_lint".to_string()); - map.insert("lint".to_string(), "utils::span_lint".to_string()); - map.insert("span_lint_note".to_string(), "utils::span_note_and_lint".to_string()); - map.insert("span_lint_help".to_string(), "utils::span_help_and_lint".to_string()); + map.insert("span_lint", "utils::span_lint"); + map.insert("struct_span_lint", "utils::span_lint"); + map.insert("lint", "utils::span_lint"); + map.insert("span_lint_note", "utils::span_note_and_lint"); + map.insert("span_lint_help", "utils::span_help_and_lint"); Self { map } } } @@ -234,8 +234,8 @@ impl<'a, 'tcx> LateLintPass<'a, 'tcx> for CompilerLintFunctions { fn check_expr(&mut self, cx: &LateContext<'a, 'tcx>, expr: &'tcx Expr) { if_chain! { if let ExprKind::MethodCall(ref path, _, ref args) = expr.node; - let fn_name = path.ident.as_str().to_string(); - if let Some(sugg) = self.map.get(&fn_name); + let fn_name = path.ident; + if let Some(sugg) = self.map.get(&*fn_name.as_str()); let ty = walk_ptrs_ty(cx.tables.expr_ty(&args[0])); if match_type(cx, ty, &paths::EARLY_CONTEXT) || match_type(cx, ty, &paths::LATE_CONTEXT);