Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please include #10502 in tag 1.69 #10685

Closed
fenollp opened this issue Apr 21, 2023 · 1 comment
Closed

Please include #10502 in tag 1.69 #10685

fenollp opened this issue Apr 21, 2023 · 1 comment
Labels
C-enhancement Category: Enhancement of lints, like adding more cases or adding help messages

Comments

@fenollp
Copy link

fenollp commented Apr 21, 2023

Description

I've looked through the diff mentioned in the CHANGELOG and it seems e9bb961 is not included.

This fixes an issue that is revealed with the latest rust stable 1.69 and should touch many users (of clap v4): clap-rs/clap#4733

I see a v1.69 tag isn't out yet, hopefully you see this and agree to this in time :)
Thanks!

Version

rustc 1.69.0 (84c898d65 2023-04-16)
binary: rustc
commit-hash: 84c898d65adf2f39a5a98507f1fe0ce10a2b8dbc
commit-date: 2023-04-16
host: x86_64-unknown-linux-gnu
release: 1.69.0
LLVM version: 15.0.7

Additional Labels

@rustbot label +C-enhancement

@rustbot rustbot added the C-enhancement Category: Enhancement of lints, like adding more cases or adding help messages label Apr 21, 2023
@blyxyas
Copy link
Member

blyxyas commented Apr 30, 2023

#10499 (The PR that fixed that issue)'s commit 6631480 was commited on Mar 14. This is after the last commit added for 1.69 on Feb 26.

I'm sorry, but it will have to wait to be stable until 1.70. You can always use nightly Clippy by updating to the Nightly toolchain with rustup default nightly or an individual nightly command by running rustup run nightly cargo clippy or rustup run +nightly cargo clippy

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Category: Enhancement of lints, like adding more cases or adding help messages
Projects
None yet
Development

No branches or pull requests

3 participants