Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new lint: suggest ptr::eq() instead of "x as *const _ as usize == y as *const as usize" #3661

Closed
matthiaskrgr opened this issue Jan 14, 2019 · 3 comments · Fixed by #6130
Closed

new lint: suggest ptr::eq() instead of "x as *const _ as usize == y as *const as usize" #3661

matthiaskrgr opened this issue Jan 14, 2019 · 3 comments · Fixed by #6130
Labels
A-lint Area: New lints good-first-issue These issues are a good way to get started with Clippy L-style Lint: Belongs in the style lint group

Comments

@matthiaskrgr
Copy link
Member

Inspired by rust-lang/rust#57547
This looks like it could be a clippy lint :)
@flip1995 flip1995 added good-first-issue These issues are a good way to get started with Clippy A-lint Area: New lints L-style Lint: Belongs in the style lint group labels Jan 14, 2019
@i-am-g2
Copy link

i-am-g2 commented Jan 16, 2019

I want to do this. Please assign this to me.

@flip1995
Copy link
Member

It's all yours! If you have any questions, we're happy to help. Just ask here or open a WIP PR.

@tesuji tesuji mentioned this issue Sep 28, 2019
Closed
@taiki-e taiki-e mentioned this issue Oct 15, 2019
Merged
@ambroisie
Copy link
Contributor

ambroisie commented Oct 6, 2020 •
edited
Loading

I would like to work on this. Should I try using the previous PR as a basis?

Edit: after reading the contributor guidelines, I will do what was written :-).

@ambroisie ambroisie mentioned this issue Oct 7, 2020
Merged
6 tasks
@bors bors closed this as completed in 947516f Oct 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-lint Area: New lints good-first-issue These issues are a good way to get started with Clippy L-style Lint: Belongs in the style lint group
Projects
None yet
Milestone
No milestone
5 participants
@matthiaskrgr @ebroto @flip1995 @ambroisie @i-am-g2