Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade UI tests to 2021 #7842

Closed
Manishearth opened this issue Oct 19, 2021 · 5 comments · Fixed by #7866
Closed

Upgrade UI tests to 2021 #7842

Manishearth opened this issue Oct 19, 2021 · 5 comments · Fixed by #7866
Labels
E-help-wanted Call for participation: Help is requested to fix this issue.

Comments

@Manishearth
Copy link
Member

Manishearth commented Oct 19, 2021 •
edited
Loading

We should upgrade our UI tests to Rust 2021

This mostly involves adding a // edition:2021 up top and ensuring the test still passes.

It's worth splitting this task up.
@Manishearth Manishearth added the E-help-wanted Call for participation: Help is requested to fix this issue. label Oct 19, 2021
@Manishearth Manishearth mentioned this issue Oct 19, 2021
Merged
@Manishearth
Copy link
Member Author

An example of something broken due to this: #7723

@camsteffen
Copy link
Contributor

Could we change this at the test suite level instead?

@Manishearth
Copy link
Member Author

Yeah @llogiq is working on that

(Sorry, I haven't been able to update issues well, I've been mostly on my phone)

@Manishearth
Copy link
Member Author

Manishearth/compiletest-rs#246

@llogiq
Copy link
Contributor

llogiq commented Oct 22, 2021

I can already report back that only a handful of tests fail with the new edition. Working through them now as I find the time.

@llogiq llogiq mentioned this issue Oct 23, 2021
Merged
@bors bors closed this as completed in 7cd9bf5 Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
E-help-wanted Call for participation: Help is requested to fix this issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

update most tests to 2021 edition rust-lang/rust-clippy
3 participants
@Manishearth @llogiq @camsteffen