range_minus_one changes range type and causes type error

[matthiaskrgr]

Summary

.

Lint Name

range_minus_one

Reproducer

I tried this code:

fn main() {
    // Simplified test case
    let _ = || 0..=1;

    // Original test case
    let full_length = 1024;
    let range = {
        // do some stuff, omit here
        None
    };

    let range = range.map(|(s, t)| s..=t).unwrap_or(0..=(full_length-1));

    assert_eq!(range, 0..=1023);
}

I saw this happen:
cargo clippy --fix -- -Aclippy::all -Wclippy::range_minus_one

after fixes were automatically applied the compiler reported errors within these files:

  * src/main.rs

This likely indicates a bug in either rustc or cargo itself,
and we would appreciate a bug report! You're likely to see
a number of compiler warnings after this message which cargo
attempted to fix but failed. If you could open an issue at
https://github.com/rust-lang/rust/issues
quoting the full output of this command we'd be very appreciative!
Note that you may be able to make some more progress in the near-term
fixing code with the `--broken-code` flag

The following errors were reported:
error[E0308]: mismatched types
   --> src/main.rs:13:53
    |
13  |     let range = range.map(|(s, t)| s..=t).unwrap_or(0..full_length);
    |                                           --------- ^^^^^^^^^^^^^^ expected struct `std::ops::RangeInclusive`, found struct `std::ops::Range`
    |                                           |
    |                                           arguments to this function are incorrect
    |
    = note: expected struct `std::ops::RangeInclusive<_>`
               found struct `std::ops::Range<{integer}>`
note: associated function defined here
   --> /home/matthias/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/core/src/option.rs:799:18
    |
799 |     pub const fn unwrap_or(self, default: T) -> T
    |                  ^^^^^^^^^

error: aborting due to previous error

For more information about this error, try `rustc --explain E0308`.
Original diagnostics will follow.

warning: an exclusive range would be more readable
  --> src/main.rs:13:53
   |
13 |     let range = range.map(|(s, t)| s..=t).unwrap_or(0..=(full_length-1));
   |                                                     ^^^^^^^^^^^^^^^^^^^ help: use: `0..full_length`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_minus_one
   = note: requested on the command line with `-W clippy::range-minus-one`

warning: `clpy` (bin "clpy" test) generated 1 warning (run `cargo fix --bin "clpy" --tests` to apply 1 suggestion)
warning: `clpy` (bin "clpy") generated 1 warning (1 duplicate)
    Finished dev [unoptimized + debuginfo] target(s) in 0.67s

I expected to see this happen:

Version

rustc 1.67.0-nightly (c5d82ed7a 2022-11-19)
binary: rustc
commit-hash: c5d82ed7a4ad94a538bb87e5016e7d5ce0bd434b
commit-date: 2022-11-19
host: x86_64-unknown-linux-gnu
release: 1.67.0-nightly
LLVM version: 15.0.4

Additional Labels

No response