diff --git a/src/libcore/num/mod.rs b/src/libcore/num/mod.rs index 011830ddb7882..a16bfde3abae0 100644 --- a/src/libcore/num/mod.rs +++ b/src/libcore/num/mod.rs @@ -569,7 +569,7 @@ macro_rules! int_impl { #[inline] pub fn abs(self) -> $T { if self.is_negative() { - self.wrapping_neg() + -self } else { self } diff --git a/src/test/run-pass/int-abs-overflow.rs b/src/test/run-pass/int-abs-overflow.rs new file mode 100644 index 0000000000000..3f50a7d6c0298 --- /dev/null +++ b/src/test/run-pass/int-abs-overflow.rs @@ -0,0 +1,21 @@ +// Copyright 2015 The Rust Project Developers. See the COPYRIGHT +// file at the top-level directory of this distribution and at +// http://rust-lang.org/COPYRIGHT. +// +// Licensed under the Apache License, Version 2.0 or the MIT license +// , at your +// option. This file may not be copied, modified, or distributed +// except according to those terms. + +// compile-flags: -Z force-overflow-checks=on + +use std::thread; + +fn main() { + assert!(thread::spawn(|| i8::min_value().abs()).join().is_err()); + assert!(thread::spawn(|| i16::min_value().abs()).join().is_err()); + assert!(thread::spawn(|| i32::min_value().abs()).join().is_err()); + assert!(thread::spawn(|| i64::min_value().abs()).join().is_err()); + assert!(thread::spawn(|| isize::min_value().abs()).join().is_err()); +}