Skip to content

Commit

Permalink
Auto merge of #18197 - alibektas:buggy_flycheck_message, r=Veykril
Browse files Browse the repository at this point in the history
minor: Stricter requirements for package wide flycheck

Require the existence of a target and `check_workspace` to be false to restart package-wide flycheck. Fixes #18194 , #18104
  • Loading branch information
bors committed Sep 27, 2024
2 parents a547bae + 99de851 commit 5fcfd95
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -380,7 +380,7 @@ fn run_flycheck(state: &mut GlobalState, vfs_path: VfsPath) -> bool {
if id == flycheck.id() {
updated = true;
match package.filter(|_| {
!world.config.flycheck_workspace(source_root_id) || target.is_some()
!world.config.flycheck_workspace(source_root_id) && target.is_some()
}) {
Some(package) => flycheck
.restart_for_package(package, target.clone().map(TupleExt::head)),
Expand Down

0 comments on commit 5fcfd95

Please sign in to comment.