From 6bb4b84806b48cbf14ed0f6223a9bc8ea66285be Mon Sep 17 00:00:00 2001
From: John Firebaugh <john.firebaugh@gmail.com>
Date: Sun, 2 Oct 2016 17:03:28 -0700
Subject: [PATCH] Add a distinct error code and description for "main function
 has wrong type"

---
 src/librustc/diagnostics.rs                | 8 ++++++++
 src/librustc/infer/error_reporting.rs      | 3 +++
 src/test/compile-fail/bad-main.rs          | 2 +-
 src/test/compile-fail/extern-main-fn.rs    | 2 +-
 src/test/compile-fail/main-wrong-type-2.rs | 2 +-
 src/test/compile-fail/main-wrong-type.rs   | 2 +-
 6 files changed, 15 insertions(+), 4 deletions(-)

diff --git a/src/librustc/diagnostics.rs b/src/librustc/diagnostics.rs
index ec09877ae121c..b863849b65626 100644
--- a/src/librustc/diagnostics.rs
+++ b/src/librustc/diagnostics.rs
@@ -1310,6 +1310,14 @@ error. To resolve it, add an `else` block having the same type as the `if`
 block.
 "##,
 
+E0330: r##"
+The `main` function is required to have the signature `fn main() { ... }`, with
+no arguments and a return type of `()`.
+
+To access command-line arguments, use `std::env::args`. To terminate the process
+with a specified exit code, use `std::process::exit`.
+"##,
+
 E0398: r##"
 In Rust 1.3, the default object lifetime bounds are expected to change, as
 described in RFC #1156 [1]. You are getting a warning because the compiler
diff --git a/src/librustc/infer/error_reporting.rs b/src/librustc/infer/error_reporting.rs
index d8a7ce72f50d2..6512a2d32ea06 100644
--- a/src/librustc/infer/error_reporting.rs
+++ b/src/librustc/infer/error_reporting.rs
@@ -604,6 +604,9 @@ impl<'a, 'gcx, 'tcx> InferCtxt<'a, 'gcx, 'tcx> {
             TypeOrigin::IfExpressionWithNoElse(_) => {
                 struct_span_err!(self.tcx.sess, span, E0317, "{}", failure_str)
             },
+            TypeOrigin::MainFunctionType(_) => {
+                struct_span_err!(self.tcx.sess, span, E0330, "{}", failure_str)
+            },
             _ => {
                 struct_span_err!(self.tcx.sess, span, E0308, "{}", failure_str)
             },
diff --git a/src/test/compile-fail/bad-main.rs b/src/test/compile-fail/bad-main.rs
index 1253f7569e7e8..cd9a7c4aac708 100644
--- a/src/test/compile-fail/bad-main.rs
+++ b/src/test/compile-fail/bad-main.rs
@@ -8,4 +8,4 @@
 // option. This file may not be copied, modified, or distributed
 // except according to those terms.
 
-fn main(x: isize) { } //~ ERROR: main function has wrong type
+fn main(x: isize) { } //~ ERROR: main function has wrong type [E0330]
diff --git a/src/test/compile-fail/extern-main-fn.rs b/src/test/compile-fail/extern-main-fn.rs
index 11f299acefa87..a93a5fb6fac6f 100644
--- a/src/test/compile-fail/extern-main-fn.rs
+++ b/src/test/compile-fail/extern-main-fn.rs
@@ -8,4 +8,4 @@
 // option. This file may not be copied, modified, or distributed
 // except according to those terms.
 
-extern fn main() {} //~ ERROR: main function has wrong type
+extern fn main() {} //~ ERROR: main function has wrong type [E0330]
diff --git a/src/test/compile-fail/main-wrong-type-2.rs b/src/test/compile-fail/main-wrong-type-2.rs
index 2878cbc7fc154..5bac13d21971b 100644
--- a/src/test/compile-fail/main-wrong-type-2.rs
+++ b/src/test/compile-fail/main-wrong-type-2.rs
@@ -9,6 +9,6 @@
 // except according to those terms.
 
 fn main() -> char {
-//~^ ERROR: main function has wrong type
+//~^ ERROR: main function has wrong type [E0330]
     ' '
 }
diff --git a/src/test/compile-fail/main-wrong-type.rs b/src/test/compile-fail/main-wrong-type.rs
index 431b855d51773..207eaff73bf9c 100644
--- a/src/test/compile-fail/main-wrong-type.rs
+++ b/src/test/compile-fail/main-wrong-type.rs
@@ -14,5 +14,5 @@ struct S {
 }
 
 fn main(foo: S) {
-//~^ ERROR: main function has wrong type
+//~^ ERROR: main function has wrong type [E0330]
 }