From a2fab457dcb6e65e119694acacc8d92fde2569c2 Mon Sep 17 00:00:00 2001 From: Eduard Bopp Date: Tue, 11 Feb 2014 00:19:27 +0100 Subject: [PATCH] Reserve `do` as a keyword Resolves issue #12157. `do` is hereby reinstated as a keyword; no syntax is associated with it though. Along the way, a unit test had to be adapted, since it was using `do` as a method identifier. Breaking changes: - Any code using `do` as an identifier will no longer work. --- src/libsyntax/parse/token.rs | 1 + src/test/compile-fail/keyword-do-as-identifier.rs | 13 +++++++++++++ .../run-pass/temporary-lifetime-for-conditions.rs | 6 +++--- 3 files changed, 17 insertions(+), 3 deletions(-) create mode 100644 src/test/compile-fail/keyword-do-as-identifier.rs diff --git a/src/libsyntax/parse/token.rs b/src/libsyntax/parse/token.rs index d32411b4f050a..1e9eab1573bdd 100644 --- a/src/libsyntax/parse/token.rs +++ b/src/libsyntax/parse/token.rs @@ -492,6 +492,7 @@ declare_special_idents_and_keywords! { (53, Typeof, "typeof"); (54, Unsized, "unsized"); (55, Yield, "yield"); + (56, Do, "do"); } } diff --git a/src/test/compile-fail/keyword-do-as-identifier.rs b/src/test/compile-fail/keyword-do-as-identifier.rs new file mode 100644 index 0000000000000..90f73f8a9f422 --- /dev/null +++ b/src/test/compile-fail/keyword-do-as-identifier.rs @@ -0,0 +1,13 @@ +// Copyright 2013 The Rust Project Developers. See the COPYRIGHT +// file at the top-level directory of this distribution and at +// http://rust-lang.org/COPYRIGHT. +// +// Licensed under the Apache License, Version 2.0 or the MIT license +// , at your +// option. This file may not be copied, modified, or distributed +// except according to those terms. + +fn main() { + let do = "bar"; //~ error: ident +} diff --git a/src/test/run-pass/temporary-lifetime-for-conditions.rs b/src/test/run-pass/temporary-lifetime-for-conditions.rs index 1985970b1071c..0716ea5cdeb4a 100644 --- a/src/test/run-pass/temporary-lifetime-for-conditions.rs +++ b/src/test/run-pass/temporary-lifetime-for-conditions.rs @@ -23,7 +23,7 @@ impl Drop for Temporary { } impl Temporary { - fn do(&self) -> bool {true} + fn do_stuff(&self) -> bool {true} } fn borrow() -> ~Temporary { ~Temporary } @@ -35,7 +35,7 @@ pub fn main() { // This loop's condition // should call `Temporary`'s // `drop` 6 times. - while borrow().do() { + while borrow().do_stuff() { i += 1; if i > 5 { break; @@ -44,7 +44,7 @@ pub fn main() { // This if condition should // call it 1 time - if borrow().do() { + if borrow().do_stuff() { unsafe { assert_eq!(DROPPED, 7) } } }