Skip to content

Commit

Permalink
Move clippy::module_name_repetitions to restriction (from `pedant…
Browse files Browse the repository at this point in the history
…ic`)

Rational:
- Too pedantic IMO, it's often better to have fine grained modules and
  then rexport stuff instead of one gigantic file
- STD doesn't do this either. Examples:
  - std::vec::Vec
  - std::collections::vec_deque::VecDequeue
- rust-clippy#7666 commonly ignored
  • Loading branch information
xFrednet committed Oct 12, 2024
1 parent 48e98ec commit 8b075fc
Show file tree
Hide file tree
Showing 4 changed files with 1 addition and 4 deletions.
2 changes: 1 addition & 1 deletion clippy_lints/src/item_name_repetitions.rs
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ declare_clippy_lint! {
/// ```
#[clippy::version = "1.33.0"]
pub MODULE_NAME_REPETITIONS,
pedantic,
restriction,
"type names prefixed/postfixed with their containing module's name"
}

Expand Down
1 change: 0 additions & 1 deletion clippy_lints/src/literal_representation.rs
Original file line number Diff line number Diff line change
Expand Up @@ -412,7 +412,6 @@ impl LiteralDigitGrouping {
}
}

#[expect(clippy::module_name_repetitions)]
pub struct DecimalLiteralRepresentation {
threshold: u64,
}
Expand Down
1 change: 0 additions & 1 deletion clippy_lints/src/macro_use.rs
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,6 @@ impl MacroRefData {
}

#[derive(Default)]
#[expect(clippy::module_name_repetitions)]
pub struct MacroUseImports {
/// the actual import path used and the span of the attribute above it. The value is
/// the location, where the lint should be emitted.
Expand Down
1 change: 0 additions & 1 deletion clippy_lints/src/vec.rs
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ use rustc_middle::ty::layout::LayoutOf;
use rustc_session::impl_lint_pass;
use rustc_span::{DesugaringKind, Span, sym};

#[expect(clippy::module_name_repetitions)]
pub struct UselessVec {
too_large_for_stack: u64,
msrv: Msrv,
Expand Down

0 comments on commit 8b075fc

Please sign in to comment.