From a9944bed3a8272cf6b1738d0d30aaf75ea7d079e Mon Sep 17 00:00:00 2001 From: onur-ozkan Date: Sun, 10 Nov 2024 22:45:09 +0300 Subject: [PATCH] handle channel info before handling git info Signed-off-by: onur-ozkan --- src/bootstrap/src/core/config/config.rs | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/src/bootstrap/src/core/config/config.rs b/src/bootstrap/src/core/config/config.rs index a93038d51d3d0..b913749ff01bc 100644 --- a/src/bootstrap/src/core/config/config.rs +++ b/src/bootstrap/src/core/config/config.rs @@ -1668,6 +1668,14 @@ impl Config { let mut lld_enabled = None; let mut std_features = None; + let is_user_configured_rust_channel = + if let Some(channel) = toml.rust.as_ref().and_then(|r| r.channel.clone()) { + config.channel = channel; + true + } else { + false + }; + let default = config.channel == "dev"; config.omit_git_hash = toml.rust.as_ref().and_then(|r| r.omit_git_hash).unwrap_or(default); @@ -1685,8 +1693,6 @@ impl Config { config.in_tree_llvm_info = GitInfo::new(false, &config.src.join("src/llvm-project")); config.in_tree_gcc_info = GitInfo::new(false, &config.src.join("src/gcc")); - let mut is_user_configured_rust_channel = false; - if let Some(rust) = toml.rust { let Rust { optimize: optimize_toml, @@ -1708,7 +1714,7 @@ impl Config { parallel_compiler, randomize_layout, default_linker, - channel, + channel: _, // already handled above description, musl_root, rpath, @@ -1745,9 +1751,6 @@ impl Config { std_features: std_features_toml, } = rust; - is_user_configured_rust_channel = channel.is_some(); - set(&mut config.channel, channel.clone()); - config.download_rustc_commit = config.download_ci_rustc_commit(download_rustc, config.llvm_assertions);