From ab5e3e66b57cded1127303d32adf35502d3e1fa0 Mon Sep 17 00:00:00 2001 From: kennytm Date: Sun, 10 Jun 2018 04:50:42 +0800 Subject: [PATCH] Added comment to explain why only RustIstaller has `llvm_tools = false`. --- src/bootstrap/tool.rs | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/bootstrap/tool.rs b/src/bootstrap/tool.rs index 595fe0ab9ad7a..0c164d86332a8 100644 --- a/src/bootstrap/tool.rs +++ b/src/bootstrap/tool.rs @@ -340,6 +340,9 @@ macro_rules! tool { } } +// FIXME(#51459): We have only checked that RustInstaller does not require +// the LLVM binaries when running. We should go through all tools to determine +// if they really need LLVM binaries, and make `llvm_tools` a required argument. tool!( Rustbook, "src/tools/rustbook", "rustbook", Mode::ToolRustc; ErrorIndex, "src/tools/error_index_generator", "error_index_generator", Mode::ToolRustc;