From ffba7b7254f9b828cf173ed066ba2d69b8831cd8 Mon Sep 17 00:00:00 2001 From: Georg Brandl Date: Sun, 1 May 2016 22:21:11 +0200 Subject: [PATCH] typeck: remove confusing suggestion for calling a fn type * It is not clear what a "base function" is. * The suggestion just adds parens, so suggests calling without args. The second point could be fixed with e.g. `(...)` instead of `()`, but the preceding "note: X is a function, perhaps you wish to call it" should already be clear enough. Fixes: #31341 --- src/librustc_typeck/check/method/suggest.rs | 4 ---- src/test/compile-fail/issue-29124.rs | 4 ---- 2 files changed, 8 deletions(-) diff --git a/src/librustc_typeck/check/method/suggest.rs b/src/librustc_typeck/check/method/suggest.rs index c5195cf8787da..31c81170f7a36 100644 --- a/src/librustc_typeck/check/method/suggest.rs +++ b/src/librustc_typeck/check/method/suggest.rs @@ -158,10 +158,6 @@ pub fn report_error<'a, 'tcx>(fcx: &FnCtxt<'a, 'tcx>, if let Some(expr) = rcvr_expr { if let Ok (expr_string) = cx.sess.codemap().span_to_snippet(expr.span) { report_function!(expr.span, expr_string); - err.span_suggestion(expr.span, - "try calling the base function:", - format!("{}()", - expr_string)); } else if let Expr_::ExprPath(_, path) = expr.node.clone() { if let Some(segment) = path.segments.last() { diff --git a/src/test/compile-fail/issue-29124.rs b/src/test/compile-fail/issue-29124.rs index b3dc043f502fc..a72dac0d5dd68 100644 --- a/src/test/compile-fail/issue-29124.rs +++ b/src/test/compile-fail/issue-29124.rs @@ -25,11 +25,7 @@ fn main() { obj::func.x(); //~^ ERROR no method named `x` found for type `fn() -> ret {obj::func}` in the current scope //~^^ NOTE obj::func is a function, perhaps you wish to call it - //~^^^ HELP try calling the base function: - //~| SUGGESTION obj::func().x(); func.x(); //~^ ERROR no method named `x` found for type `fn() -> ret {func}` in the current scope //~^^ NOTE func is a function, perhaps you wish to call it - //~^^^ HELP try calling the base function: - //~| SUGGESTION func().x(); }