Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lint on dbg! in tidy #106169

Closed
jyn514 opened this issue Dec 27, 2022 · 1 comment · Fixed by #106327
Closed

Lint on dbg! in tidy #106169

jyn514 opened this issue Dec 27, 2022 · 1 comment · Fixed by #106327
Assignees
@gimbling-away
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc E-help-wanted Call for participation: Help is requested to fix this issue. E-medium Call for participation: Medium difficulty. Experience needed to fix: Intermediate.

Comments

@jyn514
Copy link
Member

jyn514 commented Dec 27, 2022 •
edited by rustbot
Loading

This will normally be caught by UI tests if it's present in the compiler, but for other tools like compiletest or bootstrap, it can be left in unless the reviewer manually catches it. We should lint on it in tidy to avoid making the build noisier.

Originally posted by @jyn514 in #106168 (comment)
@jyn514 jyn514 added A-testsuite Area: The testsuite used to check the correctness of rustc E-help-wanted Call for participation: Help is requested to fix this issue. E-medium Call for participation: Medium difficulty. Experience needed to fix: Intermediate. labels Dec 27, 2022
@gimbling-away
Copy link
Contributor

@rustbot claim

@gimbling-away gimbling-away mentioned this issue Dec 31, 2022
Merged
@bors bors closed this as completed in d24b229 Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gimbling-away gimbling-away

Labels
A-testsuite Area: The testsuite used to check the correctness of rustc E-help-wanted Call for participation: Help is requested to fix this issue. E-medium Call for participation: Medium difficulty. Experience needed to fix: Intermediate.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add tidy check for dbg
2 participants
@jyn514 @gimbling-away